Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 128678 - net-nds/adtool-1.3 patch to work with --as-needed
Summary: net-nds/adtool-1.3 patch to work with --as-needed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Christian Andreetta (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-03 11:49 UTC by Mike Auty (RETIRED)
Modified: 2006-04-04 07:33 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
adtool-1.3-as-needed.patch (adtool-1.3-as-needed.patch,388 bytes, patch)
2006-04-03 11:49 UTC, Mike Auty (RETIRED)
Details | Diff
adtool-1.3-asneeded.patch (adtool-1.3-asneeded.patch,510 bytes, patch)
2006-04-04 04:41 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Auty (RETIRED) gentoo-dev 2006-04-03 11:49:21 UTC
This patch adds -lldap after the libactive_directory.a library, so that it's dependencies are filled when using --as-needed.  I'm not sure if this is the best way to do this, so might be worth asking flameeyes to check it over to see if it looks ok.  Otherwise should be fine, don't forget the ebuild need eautomake to be run after applying the patch.

Patch to follow.
Comment 1 Mike Auty (RETIRED) gentoo-dev 2006-04-03 11:49:53 UTC
Created attachment 83827 [details, diff]
adtool-1.3-as-needed.patch
Comment 2 Christian Andreetta (RETIRED) gentoo-dev 2006-04-04 04:05:50 UTC
flameeyes, what do you think about this patch?
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-04-04 04:41:22 UTC
Created attachment 83874 [details, diff]
adtool-1.3-asneeded.patch

Hmm I think adtool is one of the strangests autotool user I ever seen...

The problem in this case is linking ordering, as the libraries are passed in LDFLAGS instead of LDADD... also, it's usually quicker to pass them per-target instead of global, so I've done the attached patch.

It will probably require a full eautoreconf tho, as the automake seems old to me.
Comment 4 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-04-04 04:41:59 UTC
Christian, don't tell me you disabled mailing for attachments.. :P
Comment 5 Christian Andreetta (RETIRED) gentoo-dev 2006-04-04 04:54:30 UTC
(In reply to comment #4)
> Christian, don't tell me you disabled mailing for attachments.. :P

Oops! Fixed, thanks.
Anyway, I could swear it was my cat... :-D
Comment 6 Christian Andreetta (RETIRED) gentoo-dev 2006-04-04 07:33:53 UTC
in portage: thanks to both of you