Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 127917 - privoxy-3.0.3-r3 broken by compression patch
Summary: privoxy-3.0.3-r3 broken by compression patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Network Proxy Developers (OBSOLETE)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-28 13:48 UTC by Georg Sauthoff
Modified: 2006-04-06 07:31 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
quick fix (privoxy-3.0.3-gentoo-comp-fix.patch,2.03 KB, patch)
2006-03-28 13:49 UTC, Georg Sauthoff
Details | Diff
zlib patch (privoxy-3.0.3-zlib.patch,19.07 KB, patch)
2006-03-28 14:52 UTC, Alin Năstac (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Georg Sauthoff 2006-03-28 13:48:37 UTC
Hi,

it seems that you use the compression patch from:
http://sourceforge.net/tracker/index.php?func=detail&aid=895531&group_id=11118&atid=311118
Bug 83278 (no direct copy though)

The patch uses heavily '#ifdef FEATURE_ZLIB' but the ebuild does not enable it (--enable-zlib). Thus the patch has just one effect:
Privoxy now sends the Accept-Encoding html-header (with -prevent-compression in default.action) and can't decode the answer. And because of this, privoxy can't filter compressed pages any more (e.g. google) - without any error message, btw.

If you --enable-zlib, you notice some compile errors introduced by your patch. An attached patch fixes this. But this is just a quick fix. I did not do a full review of this compression patch (either your or the original version).

Because of this, I don't think that it is a good idea to enable this experimental patch by default in this ebuild. Privoxy 3.0.3 should be a stable version.

Regards
Georg Sauthoff
Comment 1 Georg Sauthoff 2006-03-28 13:49:40 UTC
Created attachment 83334 [details, diff]
quick fix
Comment 2 Alin Năstac (RETIRED) gentoo-dev 2006-03-28 14:52:08 UTC
Created attachment 83336 [details, diff]
zlib patch

Please try this patch, along with --enable-zlib in configure command line of course. It passed the google test with success.

I plan to conditionally apply it in -r4, depending on the zlib flag. This feature is too good to loose it.
Comment 3 Alin Năstac (RETIRED) gentoo-dev 2006-03-30 08:41:05 UTC
fixed in -r4.
thanks for spotting this error!
Comment 4 Georg Sauthoff 2006-04-06 07:17:23 UTC
Hi,

you're welcome. But one small thing:

I looked at -r4:
'epatch "${FILESDIR}/${P}-zlib.patch"'
should depend on the zlib useflag, too. Else the user with useflag -zlib gets
the entry '-prevent-compression' in his config and the mainly disabled patch at compile time. Thus, again compressed pages are unfiltered.

Regards
Georg Sauthoff
Comment 5 Alin Năstac (RETIRED) gentoo-dev 2006-04-06 07:31:39 UTC
ok, fixed in -r5.