Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 127729 - media-sound/xmms: gettext check in ebuild is broken
Summary: media-sound/xmms: gettext check in ebuild is broken
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Luis Medinas (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-27 03:32 UTC by Marius Mauch (RETIRED)
Modified: 2006-05-05 04:30 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marius Mauch (RETIRED) gentoo-dev 2006-03-27 03:32:57 UTC
The check for old gettext versions in xmms has several issues:
- it has to be in pkg_setup, not src_unpack, as right now it seems to create some issues with userpriv, see bug #127637. Alternatively (as this check seems to not apply for binpkgs) the ebuild should be userpriv restricted (and see below for another alternative)
- the check and the message don't match: "you seem to have USE=-nls" is not checked and also doesn't show up in the fix instructions
- the DEPEND info should be fixed to list the required gettext version instead of no version
- Actually the whole check could be dropped in favor of simply adding "!nls? ( !<sys-devel/gettext-0.14.1 )" to DEPEND, which has the benefit that the ebuild won't die at all
Comment 1 Luis Medinas (RETIRED) gentoo-dev 2006-04-23 16:55:01 UTC
feel free to change it.
Comment 2 Marius Mauch (RETIRED) gentoo-dev 2006-05-05 04:30:03 UTC
done