ToDo before this can go live: 1. http://wwwredesign.gentoo.org is now xhtml-1.0 Strict. *done 2. /css/classic.css skin complete and validates as css-2.0. Deprecates /css/main.css *done 3. /css/print.css still needs to be complete. *not started 4. Initial modularization of guide.xsl complete. Changed/new files: *done guide.xsl content.xsl ads-footer-common.xsl body-guide.xsl body-main.xsl body-misc.xsl menus.xsl news.xsl 5. /proj pages that do not validate due to invalid guideXML should be fixed in seperate bugs blocking this one. *not started 6. Guide content listing changed to a list to match handbook. *done 7. Footer is slightly different due to css constraints. *done 8. Add xhtml-valid, css-valid, gorg, gentoo icons below ads. *done 9. Add initial wrapper divs to ease future css manipulation. More are probably needed and will be added as new skin requires. Seperate styles for /mainpage and /guide are possible using only css. *done Only the underlying html was altered. All xsl functionality except Guide page content listing is unchanged. neysx, is there anything I missed or that you would like to see done differently at this stage? View live at http://wwwredesign.gentoo.org/
A hard sell as it is (almost 2 years to reach the same result), but it will make it much easier to build on it. Thanks a lot for all the time you have already put into this. > 3. /css/print.css still needs to be complete. *not started Please do not turn printable pages into B&W pages. For some of our readers, printable==readable. Besides, printable means neither has-to-be-printed, nor wysiwyp. > 5. /proj pages that do not validate due to invalid guideXML should be fixed in > seperate bugs blocking this one. *not started Haven't looked at it either. I guess project.xsl generates embedded <p>s > 7. Footer is slightly different due to css constraints. *done Personally, I don't like the way it looks on short pages (eg. http://wwwredesign.gentoo.org/doc/en/index.xml) , but I know what kind of pita it is to do with css. If no one objects to huge bottoms, I won't mind. > 8. Add gorg icon below ads. *done Nice touch, Thanks :) > neysx, is there anything I missed or that you would like to see done > differently at this stage? Text is a bit too close to the borders imo. List items are a bit too compact, increasing line height would be nice. I want my dots back (left menu) Did you leave <pre>s/, <note>s... inside a table on purpose? <pre>s need a light blue background <th> should remain <th> (not <td>), and table cells don't need to be classed I'm not too fond of the top black border on guide docs
Created attachment 83419 [details] right-hand col overlaps content right-hand column overlaps main area when narrowing window
(In reply to comment #1) > > 7. Footer is slightly different due to css constraints. *done > > Personally, I don't like the way it looks on short pages (eg. > http://wwwredesign.gentoo.org/doc/en/index.xml) , but I know what kind of pita > it is to do with css. If no one objects to huge bottoms, I won't mind. > I made the text and padding smaller so it's not so obtrusive. done > > neysx, is there anything I missed or that you would like to see done > > differently at this stage? > > Text is a bit too close to the borders imo. Added padding to content area. done > List items are a bit too compact, increasing line height would be nice. added line-height done > I want my dots back (left menu) dot is back. Not exact but close. > Did you leave <pre>s/, <note>s... inside a table on purpose? Didn't notice that. done > <pre>s need a light blue background done. > <th> should remain <th> (not <td>), and table cells don't need to be classed done > I'm not too fond of the top black border on guide docs done.
(In reply to comment #2) > Created an attachment (id=83419) [edit] > right-hand col overlaps content > > right-hand column overlaps main area when narrowing window > added z-axis to several elements. Ads now slides under the content instead of over it. Best I could come up with for the moment. I'll look into CSS columns more and fix this in the long term.
preliminary print.css up. neysx will you look at it and see if it's good enough? http://wwwredesign.gentoo.org/
Much better. I really like the adds sliding under the content. The z-axis was a good idea. It does not slide under the footer though. The same thing needs to be done on guide pages http://wwwredesign.gentoo.org/doc/en/security/index.xml Left-menu: hover needs to highlight/underline You forgot the table on http://wwwredesign.gentoo.org/security/en/index.xml Some block elements are touching each other http://wwwredesign.gentoo.org/doc/en/handbook/handbook-x86.xml?part=1&chap=10 <th> should not wrap their content inside <b>. Most browsers use bold by default, style it in the css if you want to. Printable pages should start with the title, more like on http://gentoo.neysx.org/doc/en/handbook/index.xml?style=printable Sequence should be title-abstract-authors-date Bold "Summary:" is a good idea, keep the borders as well, but please justify the abstract. Author list could be inline to save some space, justified as well, and probably better to use the same width as the summary, wider than currently, maybe narrower than full width is a good idea. Handbooks should behave the same way: http://wwwredesign.gentoo.org/doc/en/handbook/handbook-x86.xml?style=printable http://gentoo.neysx.org/doc/en/handbook/handbook-x86.xml?style=printable When actually printing (ie. not displaying) the printable page, table borders should be made black. Firefox truncated everything below the first physical page. Some overflow stuff? How about putting "Older news:" inside a blue box like newsitem headings? http://wwwredesign.gentoo.org/doc/en/list.xml list is too tight imo <e>, <brite> and <b> are now the same. Better keep the same behaviour as on www.g.o Epigraphs should be justified. http header "Content-Type: application/xhtml+xml; charset=UTF-8" should be returned to user agents that accept it. This can wait and I know it is actually my problem :) Compare the following: curl -D - -s -o /dev/null gentoo.neysx.org/ curl -H'Accept:application/xhtml+xml' -D - -s -o /dev/null gentoo.neysx.org/
(In reply to comment #6) > Much better. I really like the adds sliding under the content. The z-axis was a > good idea. It does not slide under the footer though. > The same thing needs to be done on guide pages > http://wwwredesign.gentoo.org/doc/en/security/index.xml Added z-index to guide/book pages and to footer. Ads now slide under all content. done. > > Left-menu: hover needs to highlight/underline > Done. > You forgot the table on http://wwwredesign.gentoo.org/security/en/index.xml > ummmm this is odd. Why is the <table> tag not getting class="ntable" assigned to it? I can't seem to figure this out.... > Some block elements are touching each other > http://wwwredesign.gentoo.org/doc/en/handbook/handbook-x86.xml?part=1&chap=10 There was a stray margin-bottom: 0; on some block level items. fixed. > > <th> should not wrap their content inside <b>. Most browsers use bold by > default, style it in the css if you want to. done. > > Printable pages should start with the title, more like on > http://gentoo.neysx.org/doc/en/handbook/index.xml?style=printable > Sequence should be title-abstract-authors-date Done. > Bold "Summary:" is a good idea, keep the borders as well, but please justify > the abstract. Done > Author list could be inline to save some space, justified as well, and probably > better to use the same width as the summary, wider than currently, maybe > narrower than full width is a good idea. author list is now a left floated list, much cleaner and less space. Uses same width as summary, 60%. > Handbooks should behave the same way: > done. >http://wwwredesign.gentoo.org/doc/en/handbook/handbook-x86.xml?style=printable > http://gentoo.neysx.org/doc/en/handbook/handbook-x86.xml?style=printable > > When actually printing (ie. not displaying) the printable page, table borders > should be made black. Firefox truncated everything below the first physical > page. Some overflow stuff? > created media=print style sheet. All colored items are now black/white. Bug with "overflow: auto" fixed. > How about putting "Older news:" inside a blue box like newsitem headings? > done > http://wwwredesign.gentoo.org/doc/en/list.xml list is too tight imo > increased line-height. > <e>, <brite> and <b> are now the same. > Better keep the same behaviour as on www.g.o done. > > Epigraphs should be justified. > Done. > http header "Content-Type: application/xhtml+xml; charset=UTF-8" should be > returned to user agents that accept it. This can wait and I know it is actually > my problem :) > > Compare the following: > curl -D - -s -o /dev/null gentoo.neysx.org/ > curl -H'Accept:application/xhtml+xml' -D - -s -o /dev/null gentoo.neysx.org/ > :-) I also modularized and cleaned up the css files. Neysx will you verify that everything looks good so far? I'll post a revised ToDo list later on.
(In reply to comment #0) > ToDo before this can go live: > > 3. /css/print.css still needs to be complete. *not started > *probably* done. neysx will you take a look and see if this is what you want? > 5. /proj pages that do not validate due to invalid guideXML should be fixed in > seperate bugs blocking this one. *not started > done. View live at http://wwwredesign.gentoo.org/
>> You forgot the table on http://wwwredesign.gentoo.org/security/en/index.xml > ummmm this is odd. Why is the <table> tag not getting class="ntable" assigned > to it? I can't seem to figure this out.... Look for glsa-latest in your xsl > Author list could be inline to save some space, justified as well, and probably It should be justified > created media=print style sheet. All colored items are now black/white. Not a good idea. There's no reason we should impose B&W on our readers. Besides, switching to a fixed font for printing is also not a good idea. For some reason I haven't looked into, printing in Opera does not work properly. <ti>s turn into black boxes. Forcing "courier new" in <pre> and others makes them hard to read again. That's why monospace has been put in front of the font list in the current css. The same can be said about verdana. That one at least is readable, but it still prevents browsers from using the font chosen by the user. (see bug #47104 ignoring the 80% font size issue, I know it's a lost cause) I prefer the cc-by-sa note as on http://www.gentoo.org/doc/en/xml-guide.xml#doc_chap5
*** Bug 131474 has been marked as a duplicate of this bug. ***
*** Bug 131465 has been marked as a duplicate of this bug. ***
Added to ToDo list: Menu restructure. Status: started.
docs: do we still need this bug?
(In reply to comment #13) > docs: do we still need this bug? Nope
closing it then, thanks neysx.
