Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 127166 - xfsamba won't build with GCC 4, conflicting definitions of headH
Summary: xfsamba won't build with GCC 4, conflicting definitions of headH
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GCC Porting (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 117482
  Show dependency tree
 
Reported: 2006-03-22 03:09 UTC by DC
Modified: 2006-04-30 17:31 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description DC 2006-03-22 03:09:04 UTC
Compiling xfsamba with GCC 4.1.0 gives the error:

xfsamba_mem.c:39: error: static declaration of 'headH' follows non-static declaration
xfsamba.h:243: error: previous declaration of 'headH' was here
xfsamba_mem.c: In function 'push_nmb':

This is because xfsamba.h defines:
   EXTERN nmb_history *thisH, *headH;
and xfsamba_mem.c defines:
   static nmb_history *headH;

Here's a proposed patch that seems to fix the problem:

--- xfsamba/xfsamba.h   2006-03-22 05:58:21.000000000 -0500
+++ xfsamba/xfsamba.h   2006-03-22 05:58:33.000000000 -0500
@@ -242,3 +242,3 @@ EXTERN selected_struc selected;
 EXTERN nmb_list *thisN, *headN;
-EXTERN nmb_history *thisH, *headH;
+EXTERN nmb_history *thisH;
 EXTERN void *fork_obj;
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2006-03-22 03:13:39 UTC
Uh eh, maybe someone could bump it? Latest upstream version is 4.3.3.1 and we have 0.47 in portage... o_O
Comment 2 Ryan Hill (RETIRED) gentoo-dev 2006-04-01 21:11:13 UTC
xfsamba was merged into xffm a long time ago.  xffm is part of xfce4, is in portage, and is well maintained.  this package should be kicked.
Comment 3 Mark Loeser (RETIRED) gentoo-dev 2006-04-30 17:31:36 UTC
Masked pending removal in 30 days