Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 127151 - rfc3442 support in dhclient
Summary: rfc3442 support in dhclient
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] baselayout (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Roy Marples (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on: 127149
Blocks:
  Show dependency tree
 
Reported: 2006-03-21 23:14 UTC by Alexander Zubkov
Modified: 2007-07-12 13:57 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
baselayout-rfc3442-dhclient.patch (baselayout-rfc3442-dhclient.patch,758 bytes, patch)
2006-03-21 23:16 UTC, Alexander Zubkov
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Zubkov 2006-03-21 23:14:41 UTC
Here is patch to add support of option 121 to dhclient-udhcpc-wrapper. There is also need of patch to udhcpc script (bug #127149) and setting up /etc/dhclient.conf whith "request" option containg "unknown-121".
Comment 1 Alexander Zubkov 2006-03-21 23:16:39 UTC
Created attachment 82845 [details, diff]
baselayout-rfc3442-dhclient.patch

Here is a patch made to baselayout-1.11.14-r6.
Comment 2 Roy Marples (RETIRED) gentoo-dev 2006-03-23 02:25:19 UTC
This is not going to happen for baselayout-1.11, which is where your script is based.

Infact, for the next baselayout-1.12.0_pre17 release we're moving all the code to the dhcp clients and out of baselayout helpers.d directory.

So everything is going to have to happen in /sbin/dhclient-script - and I'll only even consider patches for it against dhcp-3.0.3-r6 at a minimum in the least intrusive manner possible.

As such you may want to hold on on writing the patch for dhclient-script until we get pre17 out. I'll post back here when pre17 is done as a reminder :)
Comment 3 Alexander Zubkov 2006-03-23 02:52:24 UTC
(In reply to comment #2)

I am little confused. You saying that dhclient-script code will be in dhcp package. Then how it is bound with baselayout version? And most interesting - will it respect if user wants to use iproute or ifconfig?
Also, as I see in baselayout-1.12.0_pre16-r3 - there is no usage of /sbin/dhclient-script and there is now a more common script for all dhcp clients.
Comment 4 Roy Marples (RETIRED) gentoo-dev 2006-03-23 02:58:03 UTC
(In reply to comment #3)
> (In reply to comment #2)
> 
> I am little confused. You saying that dhclient-script code will be in dhcp
> package. Then how it is bound with baselayout version?

Well, the idea is that it won't be. It will be fully self sufficient with a minimum of fuss in baselayout.


> And most interesting -
> will it respect if user wants to use iproute or ifconfig?
> Also, as I see in baselayout-1.12.0_pre16-r3 - there is no usage of
> /sbin/dhclient-script and there is now a more common script for all dhcp
> clients.

By default no, it will use ifconfig.
Comment 5 Alexander Zubkov 2006-03-23 03:17:11 UTC
And what about my comment on current dhcp code in baselayout-1.12.0_pre16-r3?
Comment 6 Roy Marples (RETIRED) gentoo-dev 2006-03-23 04:55:12 UTC
(In reply to comment #5)
> And what about my comment on current dhcp code in baselayout-1.12.0_pre16-r3?

pre16 and earlier still use helpers.d stuff - pre17 will not force dhcp clients to use any baselayout scripts.
Comment 7 Alexander Zubkov 2006-03-23 05:01:28 UTC
(In reply to comment #6)
> pre16 and earlier still use helpers.d stuff - pre17 will not force dhcp clients
> to use any baselayout scripts.
> 
May I ask why? Is there some sort of discussion "visible" throw Internet describing this. I'm interested - why this was changed.
Comment 8 Roy Marples (RETIRED) gentoo-dev 2006-03-23 05:20:18 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > pre16 and earlier still use helpers.d stuff - pre17 will not force dhcp clients
> > to use any baselayout scripts.
> > 
> May I ask why? Is there some sort of discussion "visible" throw Internet
> describing this. I'm interested - why this was changed.
> 

No, there's no visible discussion. I maintain networking in Gentoo, am upstream for dhcpcd and maintainer for dhcpcd, pump and dhcp(dhclient) in Gentoo also. 

So pretty much what I say goes :)
If I'm unsure about something I ask fellow devs, sometimes even posting to the Gentoo -dev mailing list.

As to the why - well, it's simple. I'd like to trim down baselayout. My current snapshot is a lot lot smaller, which makes things faster. Removing a lot of crud into their packages makes overall networking a lot faster.

Don't agree with what I do then file a bug or get me on IRC and we'll talk about it then :)
Comment 9 Roy Marples (RETIRED) gentoo-dev 2007-07-12 13:57:15 UTC
Get upstream to support this please.