126835 – games-puzzle/flobopuyo: respect *FLAGS and add opengl useflag

Bug 126835 - games-puzzle/flobopuyo: respect *FLAGS and add opengl useflag

Summary: games-puzzle/flobopuyo: respect *FLAGS and add opengl useflag

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Games (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Gentoo Games

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2006-03-19 10:23 UTC by Diego Elio Pettenò (RETIRED)
Modified:	2006-03-20 12:17 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Ebuild patch (flobopuyo-ebuild.patch,1.22 KB, patch) 2006-03-19 10:24 UTC, Diego Elio Pettenò (RETIRED)	Details \| Diff
flobopuyo-0.20-libs.patch (flobopuyo-0.20-libs.patch,1.72 KB, patch) 2006-03-19 10:24 UTC, Diego Elio Pettenò (RETIRED)	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2006-03-19 10:23:38 UTC

Yet another update for flobopuyo ;)

This time it's an ebuild patch plus a makefile patch. The first one make sure that CFLAGS and LDFLAGS settings are respected correctly, it changes the set of CC and CXX to src_compile instead of src_unpack (as we need src_compile anyway), then avoids rewriting LDFLAGS and CFLAGS from the Makefile (using the big sed already present). Finally it makes opengl optional, conditional to opengl useflag (currently it was not built, but it was depending on it), and enabled only when user requires it.

The makefile patch instead makes sure that the libraries used for linking are all at the end of the linking line, so that it doesn't fail with --as-needed.

HTH,
Diego

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2006-03-19 10:24:04 UTC

Created attachment 82585 [details, diff]
Ebuild patch

Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev

2006-03-19 10:24:26 UTC

Created attachment 82586 [details, diff]
flobopuyo-0.20-libs.patch

Comment 3 Chris Gianelloni (RETIRED) gentoo-dev

2006-03-20 12:17:40 UTC

Thanks for the bug report and the patch.  You know, if you play this game a lot, you can take over maintainership of it.  Simply add yourself to metadata.xml as the maintainer and leave games as the herd.  I'm sure we won't mind.