From the log during update : >>> md5 src_uri ;-) ORBit2-2.12.5.tar.bz2 >>> Unpacking source... >>> Unpacking ORBit2-2.12.5.tar.bz2 to /var/tmp/portage/orbit-2.12.5/work * Fixing OMF Makefiles ... [ ok ] * Failed to update OMF Makefile () n22 /var/lib/portage # emerge info Portage 2.0.54 (default-linux/x86/2006.0, gcc-3.4.5, glibc-2.3.5-r2, 2.6.15-gentoo-r1 i686) ================================================================= System uname: 2.6.15-gentoo-r1 i686 Intel(R) Pentium(R) M processor 1700MHz Gentoo Base System version 1.6.14 ccache version 2.3 [enabled] dev-lang/python: 2.4.2 sys-apps/sandbox: 1.2.12 sys-devel/autoconf: 2.13, 2.59-r7 sys-devel/automake: 1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1 sys-devel/binutils: 2.16.1 sys-devel/libtool: 1.5.22 virtual/os-headers: 2.6.11-r2 ACCEPT_KEYWORDS="x86" AUTOCLEAN="yes" CBUILD="i686-pc-linux-gnu" CFLAGS="-O2 -march=pentium-m -fomit-frame-pointer -pipe" CHOST="i686-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.4/env /usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config /usr/lib/X11/xkb /usr/share/config /var/qmail/control" CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d" CXXFLAGS="-O2 -march=pentium-m -fomit-frame-pointer -pipe" DISTDIR="/usr/portage/distfiles" FEATURES="autoconfig ccache distlocks sandbox sfperms strict" GENTOO_MIRRORS="ftp://ftp-stud.fht-esslingen.de/pub/Mirrors/gentoo/ http://ftp-stud.fht-esslingen.de/pub/Mirrors/gentoo/ http://gentoo.inode.at/ http://ftp.club-internet.fr/pub/mirrors/gentoo" LINGUAS="de en" MAKEOPTS="-j2" PKGDIR="/usr/portage/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage" USE="x86 X acpi alsa apache2 arts audiofile avi berkdb bitmap-fonts bzip2 cdr cli crypt ctype cups curl dba dri dvd emboss encode exif expat fam fastbuild ffmpeg font-server foomaticdb force-cgi-redirect fortran ftp gd gdbm gif glut gpm gstreamer gtk gtk2 idn imagemagick imlib ipv6 jai java javascript jimi joystick jpeg junit kde lcms libg++ libwww live logrotate mad mbox memlimit mhash mikmod mmx mmxext mng motif mp3 mpeg mysql ncurses nls nptl nsplugin ogg opengl oss pam pcre pdflib perl php png posix python qt quicktime readline real rtc samba sdl session simplexml slp snmp soap sockets spell spl sse sse2 ssl subversion swat tcltk tcpd tiff tokenizer truetype truetype-fonts type1-fonts udev usb userlocales vorbis win32codecs xine xml xml2 xsl xv xvid yaepg zlib linguas_de linguas_en userland_GNU kernel_linux elibc_glibc" Unset: ASFLAGS, CTARGET, LANG, LC_ALL, LDFLAGS, PORTDIR_OVERLAY
Well, I see this all the time w/ various themes etc., most likely something wrong w/ the eclass.
maybe. before it would just silently fail. we'll keep an eye out for any packages that do this and try and reproduce.
(In reply to comment #2) > maybe. before it would just silently fail. we'll keep an eye out for any > packages that do this and try and reproduce. > for me "Failed to update OMF Makefile" occurs in updating (last stable): gnome-themes, libwnck, system-tools-backends, gnome-system-monitor, nautilus-cd-burner, gnome-panel, gnome-applets, file-roller, eog, metacity, epiphany, control-center.
Just got a report of it from family member. They got the OMF problem with: 'error:Failed to update OMF Makefile ()' gnome-doc-utils , gnome-themes-2.12.3 , libwnck, orbit , gnome-panel-2.12.2 and ' error:Failed to update cache with icon ()' with: gnome-panel-2.12.3 , gnome-themes-2.12.1 , gnome-themes-2.12.3
Created attachment 82567 [details, diff] patch for gnome2.eclass gnome2_omf_fix() imho the end of gnome2_omf_fix() in the gnome2.eclass should look something like this (encountered emerging gnome-extra/gconf-editor-2.12.1)
One question: Why you write: [ ! $retval -eq 0 ]] ; then instead of [ $retval -ne 0 ]] ; then ?
Created attachment 82641 [details, diff] patched gnome2.eclass omf fixing (w/ rv instead of retval) should also be rv=$? instead of retval=$? i guess. (In reply to comment #6) just cause there are a lot of those in the gnome2.eclass, so i thought it was considered good coding style ;)
Tested the patch: emerge gnome-themes Calculating dependencies ...done! >>> emerge (1 of 1) x11-themes/gnome-themes-2.12.3 to / >>> checksums files ;-) gnome-themes-2.14.0.ebuild >>> checksums files ;-) gnome-themes-2.10.0.ebuild >>> checksums files ;-) gnome-themes-2.12.1.ebuild >>> checksums files ;-) gnome-themes-2.10.2.ebuild >>> checksums files ;-) gnome-themes-2.12.3.ebuild >>> checksums files ;-) files/digest-gnome-themes-2.10.0 >>> checksums files ;-) files/digest-gnome-themes-2.10.2 >>> checksums files ;-) files/digest-gnome-themes-2.12.1 >>> checksums files ;-) files/digest-gnome-themes-2.12.3 >>> checksums files ;-) files/digest-gnome-themes-2.14.0 >>> checksums src_uri ;-) gnome-themes-2.12.3.tar.bz2 >>> Unpacking source... >>> Unpacking gnome-themes-2.12.3.tar.bz2 to /var/tmp/portage/gnome-themes-2.12.3/work [ ok ]>>> Source unpacked.les... >>> Compiling source in /var/tmp/portage/gnome-themes-2.12.3/work/gnome-themes-2.12.3 ... QA Notice: USE Flag 'doc' not in IUSE for x11-themes/gnome-themes-2.12.3 * Running elibtoolize in: gnome-themes-2.12.3 * Applying portage-1.5.10.patch ... * Applying max_cmd_len-1.5.14.patch ... * Applying sed-1.5.6.patch ... * econf: updating gnome-themes-2.12.3/config.guess with /usr/share/gnuconfig/config.guess * econf: updating gnome-themes-2.12.3/config.sub with /usr/share/gnuconfig/config.sub ./configure --prefix=/usr --host=i686-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --disable-all-themes --enable-gtk-doc --build=i686-pc-linux-gnu ............ ............ * Updating MIME database in /usr/share/mime... *** [ ok ] * Failed to update cache with icon () >>> original instance of package unmerged safely. * Installing GNOME 2 GConf schemas * Updating desktop mime database ... * Updating shared mime info database ... *** * Updating MIME database in /usr/share/mime... *** [ ok ] * Failed to update cache with icon () >>> Regenerating /etc/ld.so.cache... >>> x11-themes/gnome-themes-2.12.3 merged. The last error isn't fixed by the patch
The proposed patch in comment 7 does remove the spurious OMF error message. However, if there are real errors they are not listed correctly. My tests show 2 spurious name listed first, and the last two names are omitted. My proposed patch should list the files correctly in case of errors. It also addresses the icon error mentioned in comments 4 and 8. The downside is that the file names listed are enclosed in single quotes. The single quotes are needed to guard against file names containing spaces when building the fails lists. I have tested it by emerging nautilis-cd-burner and gnome-panel. There were no spurious errors in either case. When emerged with the original gnome2.eclass nautilis gave an OMF error, gnome-panel gave an icon cache error. I don't have a test framework to test the error cases "live". I did check with a very cut-down version and it output the list of files I expected.
Created attachment 83202 [details, diff] Alternative(better??)patch See comment #9
Added a patch to prevent the suprious error message on stable systems. Please sync and test in ~2 hours.
OK I sync'd. Verified that I have # $Header: /var/cvsroot/gentoo-x86/eclass/gnome2.eclass,v 1.67 2006/03/28 20:59:57 compnerd Exp $ Then I checked previous output of emerging gnome-themes-2.12.3 via enotice. It reported: Package: gnome-themes-2.12.3 * Failed to update OMF Makefile () * Failed to update cache with icon () I then did emerge --oneshot -v gnome-themes |tee /var/tmp/themes.out enotice reported Package: gnome-themes-2.12.3 * Failed to update OMF Makefile () * Failed to update cache with icon () * Failed to update cache with icon () And yes examination of themes.out reveals the 3 failure lines. Note that the filename of the "failing" file is (), that is, left paren right paren, not null. I patched v1.67 to change local fails=( ) to local fails In the 2 places it occurs, repeated the emerge of gnome-themes. This time there were no failure message. Don't know how this will play with bash 3.1... Anyway the 1.67 "fix" doesn't fix the problem.
OOPs, forgot to mention I'm running "mostly stable" amd64 bash-3.0-r12.
i've just committed a slight fix, this should really fix the issue :) Please test in a little while. Thanks.
Created attachment 83380 [details] Test script Today's (v 1.68) version of gnome2.eclass makes the spurious error messages go away for me. However, I cut down the fixed gnome2.eclass code to the attachment here to see what happens if there really are failure messages to report. On my system there are 14 directories in /usr/share/icons. If you force "failure" on all. only the first 13 produce a Failure message. This is with bash 3.0, don't know about 3.1. I have no idea how to trigger failure in the live situation. Maybe it is a very rare occurence and not worth an interim fix if bash 3.1 handles things correctly.
