Bug 126620 – net-misc/dhcpcd-2.0.* causes gcc warnings when compile with -pedantic

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Beech Horn 2006-03-17 20:37:46 UTC]

I have fixed a few CFLAGS="-pedantic" issues in dhcpcd and it works for 2.0.0/1/2/3.

[Comment 1 Beech Horn 2006-03-17 20:38:15 UTC]

Created attachment 82426 [details, diff]
dhcpcd-2.0-pedantic-rc1.patch

[Comment 2 Beech Horn 2006-03-17 20:40:02 UTC]

Created attachment 82427 [details]
dhcpcd-2.0.0-r1.ebuild

[Comment 3 Beech Horn 2006-03-17 20:40:18 UTC]

Created attachment 82428 [details]
dhcpcd-2.0.1-r1.ebuild

[Comment 4 Beech Horn 2006-03-17 20:40:33 UTC]

Created attachment 82429 [details]
dhcpcd-2.0.2-r1.ebuild

[Comment 5 Beech Horn 2006-03-17 20:40:47 UTC]

Created attachment 82430 [details]
dhcpcd-2.0.3-r1.ebuild

[Comment 6 Beech Horn 2006-03-17 20:41:01 UTC]

Created attachment 82431 [details]
ChangeLog

[Comment 7 Roy Marples (RETIRED) 2006-03-20 06:20:20 UTC]

Patch accepted into upstream svn repo - will be in dhcpcd-2.0.4

[Comment 8 Roy Marples (RETIRED) 2006-03-20 06:20:41 UTC]

accepting bug

[Comment 9 Beech Horn 2006-03-20 10:50:05 UTC]

Hello there, I have been doing the -pedantic patches for packages as a way of learning c/c++, I am trying to get a hang of the language and only started learning it a week ago from reading the code in existing packages.

If anyone can help remove the other -pedantic warnings:

dhcpconfig.c: In function 

[Comment 10 Beech Horn 2006-03-20 10:50:05 UTC]

Hello there, I have been doing the -pedantic patches for packages as a way of learning c/c++, I am trying to get a hang of the language and only started learning it a week ago from reading the code in existing packages.

If anyone can help remove the other -pedantic warnings:

dhcpconfig.c: In function dhcpConfig:
dhcpconfig.c:723: warning: pointer targets in passing argument 1 of cleanmetas differ in signedness
client.c: In function dhcpStart:
client.c:973: warning: ISO C forbids return between function pointer and void *
client.c: In function dhcpReboot:
client.c:996: warning: ISO C forbids return between function pointer and void *
client.c:1022: warning: ISO C forbids return between function pointer and void *
client.c: In function dhcpRequest:
client.c:1086: warning: ISO C forbids return between function pointer and void *
client.c:1125: warning: ISO C forbids return between function pointer and void *
client.c: In function dhcpBound:
client.c:1134: warning: ISO C forbids return between function pointer and void *
client.c:1139: warning: ISO C forbids return between function pointer and void *
client.c:1165: warning: ISO C forbids return between function pointer and void *
client.c: In function dhcpRenew:
client.c:1181: warning: ISO C forbids return between function pointer and void *
client.c:1186: warning: ISO C forbids return between function pointer and void *
client.c:1198: warning: ISO C forbids return between function pointer and void *
client.c:1206: warning: ISO C forbids return between function pointer and void *
client.c: In function dhcpRebind:
client.c:1212: warning: ISO C forbids return between function pointer and void *
client.c:1217: warning: ISO C forbids return between function pointer and void *
client.c:1225: warning: ISO C forbids return between function pointer and void *
client.c:1238: warning: ISO C forbids return between function pointer and void *
client.c: In function dhcpRelease:
client.c:1245: warning: ISO C forbids return between function pointer and void *
client.c:1279: warning: ISO C forbids return between function pointer and void *
client.c: In function dhcpStop:
client.c:1316: warning: ISO C forbids return between function pointer and void *
dhcpcd.c:455: warning: ISO C forbids conversion of object pointer to function pointer type
dhcpcd.c:484: warning: ISO C forbids conversion of object pointer to function pointer type


Or knows how to make a loop vectorizable:
client.c:135: note: vectorized 0 loops in function.
client.c:1173: note: vectorized 0 loops in function.
client.c:891: note: vectorized 0 loops in function.
client.c:554: note: vectorized 0 loops in function.
client.c:200: note: vectorized 0 loops in function.
client.c:809: note: vectorized 0 loops in function.
dhcpconfig.c:98: note: vectorized 0 loops in function.
dhcpconfig.c:158: note: vectorized 0 loops in function.
dhcpcd.c:150: note: vectorized 0 loops in function.

I would appreciate the knowledge and update this patch!

[Comment 11 Roy Marples (RETIRED) 2006-03-23 12:11:45 UTC]

I'm afraid that C/C++ is not my strongest language and cannot be of much help with those warnings :(

[Comment 12 Roy Marples (RETIRED) 2006-04-08 01:51:44 UTC]

2.0.4 is out