Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 126398 - Optional gettext support in app-shells/fish
Summary: Optional gettext support in app-shells/fish
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Donnie Berkholz (RETIRED)
URL: http://roo.no-ip.org/fish/
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-16 02:58 UTC by Frederik 'Freso' S. Olesen
Modified: 2006-11-01 15:54 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Frederik 'Freso' S. Olesen 2006-03-16 02:58:22 UTC
I should've filed this ages ago, but I haven't. :)

Axel, fish's upstream maintainer, has declared that gettext is optional and as such there is no need to require gettext nor install translations if the user doesn't want. This would be controlled by the 'nls' USE flag.
Also, gettext should be added in... RDEPEND, probably. Assuming 'nls' is in USE, that is. ;)

ps. 1.21.2 is out! Please add to tree, Donnie? :p
Comment 1 Donnie Berkholz (RETIRED) gentoo-dev 2006-03-16 09:34:50 UTC
(In reply to comment #0)
> Axel, fish's upstream maintainer, has declared that gettext is optional and as
> such there is no need to require gettext nor install translations if the user
> doesn't want. This would be controlled by the 'nls' USE flag.
> Also, gettext should be added in... RDEPEND, probably. Assuming 'nls' is in
> USE, that is. ;)

OK, could you attach an ebuild patch to fix this?

> ps. 1.21.2 is out! Please add to tree, Donnie? :p

Yeah, I'll get to it eventually. No real significant changes in there, and I've been working on other things.
Comment 2 Donnie Berkholz (RETIRED) gentoo-dev 2006-09-23 22:48:16 UTC
Can't fix this, configure script doesn't have an --enable/--disable-nls or -gettext flag. It uses autodetection only, which is broken. Please contact Axel about this if you're interested in getting it changed.
Comment 3 Frederik 'Freso' S. Olesen 2006-11-01 11:40:37 UTC
Wouldn't a possible solution be to only depend on gettext if "nls" is in USE? That way, if nls isn't in the system to begin with, it won't have to pull in gettext and since gettext doesn't exist, fish won't use it?

Anyway, Axel? Do you think you can put in a configure flag to force enable/disable gettext support? (I'd imagine one is able to leave it on auto-discovery if neither has been specified... ?)
Comment 4 Donnie Berkholz (RETIRED) gentoo-dev 2006-11-01 15:54:33 UTC
(In reply to comment #3)
> Wouldn't a possible solution be to only depend on gettext if "nls" is in USE?
> That way, if nls isn't in the system to begin with, it won't have to pull in
> gettext and since gettext doesn't exist, fish won't use it?

No. The result isn't deterministic in the USE=-nls case, because gettext could either be installed or not installed. Also, it's possible to have a package installed, yet not want support for it in every other package.