Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 126389 - Simplified warn_trampolines patch for gcc-4.1.0
Summary: Simplified warn_trampolines patch for gcc-4.1.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-15 23:39 UTC by Kevin F. Quinn (RETIRED)
Modified: 2006-03-19 05:52 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Tidier patch to add -Wtrampolines; replacement for 00_all_gcc-trampolinewarn.patch (gcc-4.1.0-trampolinewarn.patch,1.07 KB, patch)
2006-03-15 23:41 UTC, Kevin F. Quinn (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin F. Quinn (RETIRED) gentoo-dev 2006-03-15 23:39:44 UTC
Sorry, I should have provided this earlier - I reworked the warn_trampolines patch for 4.1.0.  While the existing one works, it's not in the new style for such things in gcc-4.1.0.  The new patch I'll attach in a moment is much simpler, and should be trivial to maintain going forward.
Comment 1 Kevin F. Quinn (RETIRED) gentoo-dev 2006-03-15 23:41:46 UTC
Created attachment 82266 [details, diff]
Tidier patch to add -Wtrampolines; replacement for 00_all_gcc-trampolinewarn.patch
Comment 2 Mark Loeser (RETIRED) gentoo-dev 2006-03-16 10:28:28 UTC
Did this default to on before?  I personally would prefer it to be off since it could break even more builds that use -Werror, and it would be nice to keep the default behaviour as close to upstream as possible.
Comment 3 Kevin F. Quinn (RETIRED) gentoo-dev 2006-03-16 12:22:59 UTC
It did, yes; default was '1'.

To change that, just remove the 'Init(1)' bit and it'll default to off.
Comment 4 SpanKY gentoo-dev 2006-03-16 15:51:46 UTC
updated patch in cvs with this version

Kevin: could you send a proper ChangeLog-ed version with the warning defaulting to off to gcc-patches and cc toolchain ?  any questions, just grab me on irc ...
Comment 5 Kevin F. Quinn (RETIRED) gentoo-dev 2006-03-19 05:52:09 UTC
Submission upstream is in progress, but obviously will default to off.

I think defaulting it to on for everyone is not a good idea.  I think a better way to switch it on "by default" would be to add it to the specs; fex.

-------- Wtrampolines.specs --------
*cc1:
+ %{!Werror: -Wtrampolines}

-------------------------------------

which could be done by interested parties through GCC_SPECS, rather than forcing it to all users.

Now GCC_SPECS supports multiple entries, we could supply a whole range of useful little specs files like that, either along with the gcc ebuild or perhaps separately.