Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 126103 - games-action/powermanga-0.79 doesn't check for mikmod use flag on sdl-mixer
Summary: games-action/powermanga-0.79 doesn't check for mikmod use flag on sdl-mixer
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: Lowest enhancement (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-13 19:10 UTC by Forester
Modified: 2006-03-15 14:59 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Forester 2006-03-13 19:10:09 UTC
When emerging powermanaga no check is perfomed to ensure that sdl-mixer was compiled with mikmod use flag enabled. mikmod is required to ensure sound files can be played during the game. If sdl-mixer is compiled without mikmod the game will still play but without any sound and report that an "Unsupported music file" was used if loaded from a shell session.

I know I'm being a bit picky, this is not critical but it may be handy to a begineer if they're made aware of this during the ebuild.

An example change (untested) to the ebuild could be...

src_compile() {
    if ! built_with_use media-libs/sdl-mixer mikmod; then
        eerror "powermanga needs sdl-mixer compiled with mikmod use-flag enabled!"
        die "sdl-mixer without mikmod detected"
    fi

    egamesconf --prefix=/usr || die "egamesconf failed"
    emake || die "emake failed"
}

Obviously it isn't neccessary to die, it could just do an ewarn instead.
Comment 1 Chris Gianelloni (RETIRED) gentoo-dev 2006-03-15 14:59:33 UTC
Fixed in CVS... thanks for the bug report...