laptopmode.sh which comes with pbbuttonsd-0.7.4 ebuild always sets "atime" option for mount when exiting laptop mode. I have noatime set in my fstab for root reiserfs partition and it'd be great if laptopmode.sh honored this. Commneting out line 284 in laptopmode.sh solves this problem for me, although I don't think this is the righ fix :).
No, it should already be parsing your fstab and using the correct option. Can you please attach your fstab file?
(In reply to comment #1) # /etc/fstab: static file system information. # $Header: /home/cvsroot/gentoo-src/rc-scripts/etc/fstab,v 1.10 2002/11/18 19:39:22 azarah Exp $ # # noatime turns of atimes for increased performance (atimes normally aren't # needed; notail increases performance of ReiserFS (at the expense of storage # efficiency). It's safe to drop the noatime options if you want and to # switch between notail and tail freely. # <fs> <mountpoint> <type> <opts> <dump/pass> # NOTE: If your BOOT partition is ReiserFS, add the notail option to opts. /dev/hda12 / reiserfs noatime 0 0 /dev/hda11 none swap sw 0 0 /dev/hda10 /mnt/osx hfsplus ro 0 0 proc /proc proc defaults 0 0 # glibc 2.2 and above expects tmpfs to be mounted at /dev/shm for # POSIX shared memory (shm_open, shm_unlink). Adding the following # line to /etc/fstab should take care of this: # (tmpfs is a dynamically expandable/shrinkable ramdisk, and will use almost no # memory if not populated with files) tmpfs /dev/shm tmpfs defaults 0 0 /dev/sda3 /mnt/ipod hfsplus defaults,ro,uid=1000,gid=100,user,noauto 0 0 /dev/sr0 /mnt/cdrom auto ro,noauto,user,exec /dev/hde1 /mnt/canon vfat defaults,noauto,ro,uid=1000,gid=100,user
I still can't reproduce this. Does it happen with 0.7.6? Can you print the value of PARSEDOPTS after that line?
I've tracked down the problem -- this breaks when /etc/fstab has tabs instead of spaces. The patch is a one-liner. I checked the latest version of pbbuttonsd in the tree (0,7,8) and the bug is still there. JoseJX: What's your opinion on patching the older pbbuttonsd versions? Maybe it's time to clean some of them out, since there are now 3 stable versions? Also, do you want to submit the patch upstream since you've been working with them already?
Created attachment 95098 [details, diff] make laptopmode.sh respect noatime
Thanks for looking into this Wormo. :) Feel free to pass the patch upstream, there's no need for me to be involved. (unless you don't want to do it that is). As for the old versions, we certainly can clean them out. I kept 0.6.6 in the tree because there was a lot of complaining about versions after that (IPC change). As for the 0.7.x versions, I just haven't cleaned them out in a while. :| Next time there's a version bump, I'll get rid of the extras.
Ok, I went ahead and patched all the existing versions, letting JoseJX decide which old abuilds to clean up at some future time ;) Upstream has been notified, so the fix should make it into future versions.
