Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 125950 - dev-dotnet/gtk-sharp-2.8.0: broken libtoolize handling and unrespected CFLAGS
Summary: dev-dotnet/gtk-sharp-2.8.0: broken libtoolize handling and unrespected CFLAGS
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: dotnet project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-12 09:27 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2006-04-16 11:30 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild patch (gtk-sharp-ebuild.patch,1.05 KB, patch)
2006-03-12 09:27 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2006-03-12 09:27:14 UTC
Currently handling of libtoolize in gtk-sharp is broken: it's run after aclocal and autoconf (it should be run before them), and should be under an || die condition (probably now it is because it's run after the other and might fail).

Easy solution: use eautoreconf from autotools eclass like the attached patch does.

Thanks,
Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-03-12 09:27:29 UTC
Created attachment 81985 [details, diff]
Ebuild patch
Comment 2 Peter Johanson (RETIRED) gentoo-dev 2006-03-14 21:29:49 UTC
Diego: Why blast the WANT_AUTOMAKE part? Does eautoreconf handle knowing those details as well?
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-03-17 04:50:25 UTC
Yes, eautoreconf takes care of everything (well it's more the autoconf/automake wrappers) unless you want to force an upgrade (say the configures are for autoconf 2.1 and you want to force them to be built with 2.5).

Also, the package does not respect CFLAGS (but it does respect LDFLAGS), as the configure.in rewrites them with -g and a bunch of -W flags. If you just run

sed -i -e '/^CFLAGS=/d' ${S}/configure.in

before eautoreconf, CFLAGS are respected (the one they were rewritten with are dropped as it should be, -g is an user choice, the warnings are for developers mainly). This solution is good for an ebuild but to be sent upstream it requires different handling, and as I don't know upstream, you might be better in that :)
Comment 4 Peter Johanson (RETIRED) gentoo-dev 2006-04-16 11:30:59 UTC
Ok, Commited this fix to gtk-sharp-2.{4,8}.2, as well as similar fixes to the gtk-sharp-componenent.eclass.

Marking this FIXED, feel free to re-open if there's further issues.

Thanks for the patch.