Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 125674 - perl-cleaner efficiency and speed
Summary: perl-cleaner efficiency and speed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Perl team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-10 00:44 UTC by Wade Fitzpatrick
Modified: 2006-07-08 08:32 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to replace grep with fgrep where appropriate (perl-cleaner.fgrep.patch,3.58 KB, patch)
2006-03-10 00:46 UTC, Wade Fitzpatrick
Details | Diff
Patch to add esearch speed improvements (perl-cleaner.full.patch,11.56 KB, patch)
2006-03-10 00:53 UTC, Wade Fitzpatrick
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wade Fitzpatrick 2006-03-10 00:44:44 UTC
app-admin/perl-cleaner-1.01 is horrendously slow due to massive use of grep instead of fgrep. Also should make use of esearch cache if available.

Stand by for patch...
Comment 1 Wade Fitzpatrick 2006-03-10 00:46:50 UTC
Created attachment 81821 [details, diff]
Patch to replace grep with fgrep where appropriate

Also fixes some formatting and adds a vim modeline
Comment 2 Wade Fitzpatrick 2006-03-10 00:53:15 UTC
Created attachment 81822 [details, diff]
Patch to add esearch speed improvements

Includes fgrep fixes and adds support of esearch cache so we don't have to keep calling emerge all the time.

Without this patch:
real    42m31.915s
user    36m9.454s
sys     0m23.254s

With this patch:
real    0m3.895s
user    0m2.311s
sys     0m0.405s

Both returned exactly the same list of packages to emerge (103 packages)
Comment 3 Michael Cummings (RETIRED) gentoo-dev 2006-03-10 15:05:34 UTC
I'll admit I haven't had a chance to look over the patches yet - but where were you when we put this together? :) Thanks, will take a peak soon,

~mcummings
Comment 4 Michael Cummings (RETIRED) gentoo-dev 2006-07-08 08:32:50 UTC
applied for the most part. ran into a little problem with some overzealous fgrep replacements, but all in all this is in the 1.04 series