125545 – net-misc/rdesktop strips binary

Bug 125545 - net-misc/rdesktop strips binary

Summary: net-misc/rdesktop strips binary

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High minor
Assignee:	Chris Gianelloni (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2006-03-08 16:54 UTC by Diego Elio Pettenò (RETIRED)
Modified:	2006-07-20 15:42 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2006-03-08 16:54:53 UTC

net-misc/rdesktop by default strips the rdesktop binary, making debug impossible also when built with -ggdb.

A simple sed -i -e 's:strip:true:' ${S}/Makefile.in before econf will fix it.

Thanks,
Diego

Comment 1 Chris Gianelloni (RETIRED) gentoo-dev

2006-03-16 13:09:37 UTC

Fixed in CVS... thanks for the bug report and the sed... making it all too easy one me, you know...

Comment 2 Jakub Moc (RETIRED) gentoo-dev

2006-07-20 13:35:02 UTC

Doesn't work any more in 1.5.0_rc1.

QA Notice: pre-stripped files found:
/var/tmp/portage/rdesktop-1.5.0_rc1/image/usr/bin/rdesktop

A new patch:

--- rdesktop-1.5.0_rc1.ebuild.orig	2006-07-05 18:14:52.000000000 +0200
+++ rdesktop-1.5.0_rc1.ebuild	2006-07-20 22:33:19.000000000 +0200
@@ -33,7 +33,9 @@
 
 src_compile() {
 	sed -i -e '/-O2/c\' -e 'cflags="$cflags ${CFLAGS}"' configure
-	sed -i -e 's:strip:true:' Makefile.in
+	local strip="$(echo '$(STRIP) $(DESTDIR)$(bindir)/rdesktop')"
+	sed -i -e "s:${strip}::" Makefile.in \
+		|| die "sed failed in Makefile.in"
 	econf \
 		--with-openssl=/usr \
 		`use_with debug` \

Comment 3 Chris Gianelloni (RETIRED) gentoo-dev

2006-07-20 15:42:22 UTC

Fixed in CVS... thanks for the patch...