Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 125451 - dev-php/PEAR-Mail_Mime php-5.1 E_STRICT
Summary: dev-php/PEAR-Mail_Mime php-5.1 E_STRICT
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: PHP Bugs
URL: http://pear.php.net/bugs/bug.php?id=7057
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-08 02:07 UTC by Christian Skarby
Modified: 2007-08-16 10:30 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Adds php 5 compliance patch when USE=php5 is active (ebuild.patch,939 bytes, patch)
2006-03-08 02:12 UTC, Christian Skarby
Details | Diff
PEAR-Mail_Mime/php5 reference passing (php5.patch,2.81 KB, patch)
2006-03-08 02:14 UTC, Christian Skarby
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Skarby 2006-03-08 02:07:43 UTC
Reference passing for objects is changed in php 5, triggering a lot of
E_STRICT errors. Please review appended patch which should make dev-php/PEAR-Mail_Mime php5 compliant. Note that there is quite some time since I wrote ebuilds regularily, so there might be an better approach than adding a local use-flag.
Comment 1 Christian Skarby 2006-03-08 02:12:21 UTC
Created attachment 81673 [details, diff]
Adds php 5 compliance patch when USE=php5 is active
Comment 2 Christian Skarby 2006-03-08 02:14:06 UTC
Created attachment 81674 [details, diff]
PEAR-Mail_Mime/php5 reference passing
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2006-03-08 02:45:30 UTC
We definitely won't be adding php4/php5 use flags. ;)
Comment 4 Luca Longinotti (RETIRED) gentoo-dev 2006-03-08 03:58:10 UTC
If this patch fixes the pass-by-reference errors in PHP5 I don't see why we wouldn't want to apply this also on PHP4 since there are probably the same errors there, so I don't really see a need for an USE flag. ;)
I'll see to add the patch to our PEAR-Mail packages during the day and hopefully upstream will fix this too in the next releases as it looks like a relatively easy fix that shouldn't break anything.
Best regards, CHTEKK.
Comment 5 Luca Longinotti (RETIRED) gentoo-dev 2006-03-09 12:48:06 UTC
The patch was added to dev-php/PEAR-Mail_Mime-1.3.1-r2, which is currently marked unstable. Please emerge --sync in a few hours and test the new release, the patch applies fine.
Best regards, CHTEKK.
Comment 6 Jakub Moc (RETIRED) gentoo-dev 2007-08-16 10:30:47 UTC
Still unfixed in 1.5.2 (!), please report this upstream, not really keen on porting this patch over and over again.

http://pear.php.net/bugs/search.php?cmd=display&package_name[0]=Mail_Mime