Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 125361 - app-accessibility/festival-it-0.1.ebuild (New Package) - italian support
Summary: app-accessibility/festival-it-0.1.ebuild (New Package) - italian support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: Jesus Rivero (RETIRED)
URL: http://www.pd.istc.cnr.it/TTS/It-FEST...
Whiteboard:
Keywords: EBUILD
: 128350 141598 (view as bug list)
Depends on: 125355
Blocks:
  Show dependency tree
 
Reported: 2006-03-07 07:33 UTC by Francesco Monica
Modified: 2009-05-07 14:45 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
app-accessibility/festival-it-0.1 (festival-it-0.1.ebuild,2.31 KB, text/plain)
2006-03-07 07:34 UTC, Francesco Monica
Details
patch against festival-1.4.3-r4.ebuild to add italian support when linguas_it is enabled (festival-it.diff,1.71 KB, patch)
2006-04-13 00:11 UTC, Bruno Redondi
Details | Diff
patch against festival-1.95_beta.ebuild to add italian support when linguas_it is enabled (festival-1.95_beta-it.diff,2.14 KB, patch)
2006-05-18 00:02 UTC, Bruno Redondi
Details | Diff
patch against festival-1.95_beta-r1.ebuild to add italian support when linguas_it is enabled (it_festival.diff,2.56 KB, patch)
2006-09-21 01:28 UTC, Bruno Redondi
Details | Diff
sand-alone ebuild for italian linguas (festival-it-1.0.ebuild,2.30 KB, text/plain)
2006-10-10 01:53 UTC, Francesco Monica
Details
festival-it-1.0.ebuild, stand-alone ebuild for italian linguas (festival-it-1.0.ebuild,2.30 KB, text/plain)
2006-10-10 01:54 UTC, Francesco Monica
Details
festival-it-1.0.ebuild, monolitic archive version (festival-it-1.0.ebuild,2.22 KB, text/plain)
2006-10-12 09:35 UTC, Francesco Monica
Details
src_uri correction, check for mbrola built_with_use linguas_it (festival-it-1.0.ebuild,2.29 KB, text/plain)
2008-02-26 13:26 UTC, ranaldo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Francesco Monica 2006-03-07 07:33:45 UTC
Hi!

Please find attached festival-it-0.1.ebuild. This package adds support for italian voices to the Festival TTS (app-accessibility/festival-1.4.3-r4).

This ebuild installs two new voices: "lp_diphone" and "pc_diphone". If the USE variable "mbrola" is set, also "lp_mbrola" and "pc_mbrola" voices are installed.

The mbrola-based voices need app-accessibility/mbrola package with italian language support enabled. I've submitted an updated version of the mbrola ebuild with bugzilla bug #125355.

I'm not sure if the best way to add italian support to festival is a stand-alone ebuild like this or an update of the app-accessibility/festival ebuild (dealing with linguas_it variable). Let me know which one you prefer.

Regards,
Francesco.
Comment 1 Francesco Monica 2006-03-07 07:34:58 UTC
Created attachment 81603 [details]
app-accessibility/festival-it-0.1
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2006-04-01 00:48:34 UTC
*** Bug 128350 has been marked as a duplicate of this bug. ***
Comment 3 Bruno Redondi 2006-04-13 00:11:15 UTC
Created attachment 84536 [details, diff]
patch against festival-1.4.3-r4.ebuild to add italian support when linguas_it is enabled
Comment 4 Bruno Redondi 2006-05-18 00:02:26 UTC
Created attachment 86981 [details, diff]
patch against festival-1.95_beta.ebuild to add italian support when linguas_it
is enabled
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2006-07-24 09:19:46 UTC
*** Bug 141598 has been marked as a duplicate of this bug. ***
Comment 6 Bruno Redondi 2006-09-21 01:28:14 UTC
Created attachment 97614 [details, diff]
patch against festival-1.95_beta-r1.ebuild to add italian support when linguas_it is enabled
Comment 7 William Hubbs gentoo-dev 2006-10-07 11:33:14 UTC
I believe this will work better as a separate ebuild.  Can you please verify whether or not the ebuild you originally submitted to this bug is still up to date?  Also, I would recommend using the same version number and package name as upstream, so it would be italian-festival-1.0.ebuild.

Also, is there a particular reason you downloaded the files individually instead of using the single .zip file from upstream that includes everything?

Thanks much.

Comment 8 Francesco Monica 2006-10-10 01:53:43 UTC
Created attachment 99261 [details]
sand-alone ebuild for italian linguas
Comment 9 Francesco Monica 2006-10-10 01:54:46 UTC
Created attachment 99262 [details]
festival-it-1.0.ebuild, stand-alone ebuild for italian linguas
Comment 10 Francesco Monica 2006-10-10 02:33:06 UTC
(In reply to comment #7)
> I believe this will work better as a separate ebuild. Can you please verify
> whether or not the ebuild you originally submitted to this bug is still up to
> date?  Also, I would recommend using the same version number and package name
> as upstream, so it would be italian-festival-1.0.ebuild.

I've updated the ebuild version number as you suggested and I've made some little adjustments to make it up to date. The new version perfectly work on my setup, togheter with stable version of mbrola and festival:

app-accessibility/mbrola-3.0.1h-r4  LINGUAS="it% -de% -es% -fr% -ro%"
app-accessibility/festival-1.4.3-r4  USE="doc mbrola -asterisk" LINGUAS="-es%" 
app-accessibility/festival-it-1.0  USE="mbrola" LINGUAS="it%"

I've not yet tested any masked version of festival package.


> Also, is there a particular reason you downloaded the files individually
> instead of using the single .zip file from upstream that includes everything?

The single zipfile "Italian-FESTIVAL-v1.0.zip" (available also from sourceforge) is about 20Mb, and contains a bunch of additional zipfiles. Some of them are in fact unuseful (~8Mb) so I preferred download the single ones to save some download time.

Let me know if you have other suggestions.

Bye.
Comment 11 William Hubbs gentoo-dev 2006-10-10 17:42:32 UTC
I would be more comfortable if we used the italian-festival-v1.0.zip file from upstream instead of downloading the individual files.  The reason for this is that if we download the individual files we can only have one version of this package in the portage tree at a time since the individual files do not have a version number.

Do you mind re-working the ebuild to use this file?

Thanks much.
Comment 12 Francesco Monica 2006-10-12 09:35:54 UTC
Created attachment 99445 [details]
festival-it-1.0.ebuild, monolitic archive version
Comment 13 Francesco Monica 2006-10-12 09:51:19 UTC
(In reply to comment #11)
> I would be more comfortable if we used the italian-festival-v1.0.zip file from
> upstream instead of downloading the individual files.  The reason for this is
> that if we download the individual files we can only have one version of this
> package in the portage tree at a time since the individual files do not have a
> version number.

Easy to do: new ebuild posted (attachment id=99445).

Only a question: every file needs a version numer in its name?
Please note that every file downloaded by the script, monolitic or not, is hosted in a directory containing the version numer in its name. For example:
http://www.pd.istc.cnr.it/software/It-Festival/1.0/italian_scm.zip
                                               ^^^
Looking at the ebuild, you can see that every change in the PV string will reflects in the actual SRC_URI.

May I have misunderstood the problem?

Bye!
Comment 14 William Hubbs gentoo-dev 2007-09-03 02:48:27 UTC
(In reply to comment #13)
> Easy to do: new ebuild posted (attachment id=99445).
> Only a question: every file needs a version numer in its name?
> Please note that every file downloaded by the script, monolitic or not, is
> hosted in a directory containing the version numer in its name. For example:
> http://www.pd.istc.cnr.it/software/It-Festival/1.0/italian_scm.zip
>                                                ^^^
> Looking at the ebuild, you can see that every change in the PV string will
> reflects in the actual SRC_URI.
> May I have misunderstood the problem?
> Bye!

First, I would like to appologise for taking so long to get back to you on this; I definitely have not forgotten about it.

My concern with the previous ebuild was this.  When a new ebuild is put into portage, the source files are copied onto gentoo's mirrors.  If the files do not have  a version number in the name, and a new version of the package comes along, it will over-write the previous one when the files are copied to our mirrors.

Have you tested these voices yet with festival 1.96-beta?

Thanks,

William
Comment 15 Francesco Monica 2007-09-03 07:03:22 UTC
(In reply to comment #14)

> My concern with the previous ebuild was this.  When a new ebuild is put into
> portage, the source files are copied onto gentoo's mirrors.  If the files do
> not have  a version number in the name, and a new version of the package comes
> along, it will over-write the previous one when the files are copied to our
> mirrors.

Ok. I got it!

> Have you tested these voices yet with festival 1.96-beta?

Not yet. I'm pretty busy by now, but I'll probably need to use festival in the near future, so I will send you additional information asap.

Bye,
Francesco.
Comment 16 William Hubbs gentoo-dev 2008-01-13 17:30:29 UTC
Can you please re-open this bug when you have had an opportunity to test against the latest festival and let me know if these voices still work?

Thanks much,

William
Comment 17 ranaldo 2008-02-26 13:07:05 UTC
(In reply to comment #16)
> Can you please re-open this bug when you have had an opportunity to test
> against the latest festival and let me know if these voices still work?
> 
> Thanks much,
> 
> William
> 

I modified the ebuild to correct src_uri and some other little things.
Voices works well on festival-1.96_beta.
Comment 18 ranaldo 2008-02-26 13:20:06 UTC
(In reply to comment #16)
> Can you please re-open this bug when you have had an opportunity to test
> against the latest festival and let me know if these voices still work?
> 
> Thanks much,
> 
> William
> 

May some one reopen to upload ebuild?
Inline patch:

--- festival-it-1.0.ebuild      2008-02-26 14:13:44.000000000 +0100
+++ festival-it-1.0.ebuild.new  2008-02-26 14:15:06.000000000 +0100
@@ -1,13 +1,13 @@
 # Copyright 1999-2006 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
 # $Header: $
+inherit eutils

 IUSE="mbrola linguas_it"

 DESCRIPTION="A collection of italian voices for Festival TTS."
 HOMEPAGE="http://www.pd.istc.cnr.it/TTS/It-FESTIVAL.htm"
-MY_HOME="http://www.pd.istc.cnr.it/software/It-Festival/${PV}"
-SRC_URI="mirror://sourceforge/"
+SRC_URI="mirror://sourceforge/it-festival/Italian-FESTIVAL.zip"

 RDEPEND=">=app-accessibility/festival-1.4.3-r4
          mbrola? (>=app-accessibility/mbrola-3.0.1h-r4)"
@@ -19,13 +19,13 @@ LICENSE="GPL-2"
 KEYWORDS="~alpha ~amd64 ~hppa ~ia64 ~ppc ~ppc64 ~sparc ~x86"

 pkg_setup () {
-       if use mbrola && ! use linguas_it; then
+       if use mbrola && ! built_with_use app-accessibility/mbrola linguas_it; then
          einfo "You should emerge app_accessibility/mbrola with italian support"
          einfo "in order to enable mbrola-based italian voices in festival."
          einfo
          einfo "Try to add \"it\" to your LINGUAS string in /etc/make.conf"
          einfo "and re-emerge app_accessibility/mbrola"
-         die
+         die   "mbrola has no italian support please remerge it with LINGUAS=it"
        fi
 }

@@ -68,7 +68,6 @@ src_unpack () {
        rm -rf festival/
 }

-
 src_install () {
        # Install the docs
        dodoc ${WORKDIR}/docs/*



Comment 19 ranaldo 2008-02-26 13:26:18 UTC
Created attachment 144675 [details]
src_uri correction, check for mbrola built_with_use linguas_it

Sorry as the new ebuild can be uploaded if the bug is closed.
Comment 20 William Hubbs gentoo-dev 2008-03-03 14:42:31 UTC
Re-opening bug.
Comment 21 William Hubbs gentoo-dev 2009-03-15 18:06:51 UTC
I am assigning this to our new festival maintainer.
Comment 22 Jesus Rivero (RETIRED) gentoo-dev 2009-05-07 14:45:41 UTC
# ChangeLog for app-accessibility/festival-it
# Copyright 1999-2009 Gentoo Foundation; Distributed under the GPL v2
# $Header: /var/cvsroot/gentoo-x86/app-accessibility/festival-it/ChangeLog,v 1.1 2009/05/07 14:43:40 neurogeek Exp $

*festival-it-1.0 (07 May 2009)

  07 May 2009; Jesus Rivero <neurogeek@gentoo.org> +festival-it-1.0.ebuild:
  Initial commit. Thanks to Francesco Monica and Bruno Redondi. Closes bug
  #125361

Thanks guys for the hard work, and forgive the time it took. 

Best regards,