Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 125198 - gbuffy bugs (whitespace in folder names; efficiency)
Summary: gbuffy bugs (whitespace in folder names; efficiency)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Other
: High enhancement (vote)
Assignee: Aron Griffis (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-06 01:42 UTC by Phil Pennock
Modified: 2006-03-24 22:20 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Wrap folder-names in quotes in IMAP protocol (gbuffy-1.patch,2.49 KB, patch)
2006-03-06 01:44 UTC, Phil Pennock
Details | Diff
Optimise new-mail fetching on large folders (gbuffy-search-3.patch,2.95 KB, patch)
2006-03-06 01:46 UTC, Phil Pennock
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Phil Pennock 2006-03-06 01:42:44 UTC
I've submitted two patches for gbuffy-0.2.6 to the maintainer.  No response on either.  I'm not sure if upstream is dead.  Can Gentoo consider pulling these patches in, please?

The first patch, whitespace-in-foldernames, was submitted 2005-03-16.  The second, fixing a mistaken assumption about new mails, 2006-01-23.

Will attach patches as files once this bug is filed, since the UI doesn't let me attach them now.
Comment 1 Phil Pennock 2006-03-06 01:44:59 UTC
Created attachment 81493 [details, diff]
Wrap folder-names in quotes in IMAP protocol
Comment 2 Phil Pennock 2006-03-06 01:46:18 UTC
Created attachment 81494 [details, diff]
Optimise new-mail fetching on large folders

In gbuffy (0.2.6), there's a comment for imap.c:parse_fetch() which
states:
 /* Ok, now fetch all the headers from the first UNSEEN through the
  * end of the mailbox.  This could be lower bandwidth (maybe) by first
  * fetching all of the flags, and then only fetching the headers of
  * the messages which are new, but there is a lot of protocol crap
  * which would probably negate the lower bandwidth */

Unfortunately, when using a threaded mail-client and skipping some
uninteresting threads which keep receiving email, the range of seen vs
unseen mails can become rather large.

The attached patch renames parse_fetch() to parse_fetch_range() and
implements a new parse_fetch() which does a SEARCH first.  In my
testing, this takes the time to view 4 new mails in a large folder from
over 10 seconds (thanks to the X-Face fetch bypassing server-side
caches) down to less than 1 second.
 
The extra protocol overhead consists of issuing SEARCH RECENT UNSEEN,
taking the numerical ranges, assuming that the server hasn't done any
doubled whitespace or other syntactical violations and just changing the
spaces to commas, to issue a comma-separated sequence set to the
subsequent FETCH.  So really it's one extra command and a slightly
longer variation on an existing command.
Comment 3 Phil Pennock 2006-03-13 13:44:27 UTC
I'm going to be the maintainer for gbuffy-0.2.7 onwards, barring mishap.  Please pull in the patches, since they're already in my repository for the next release; that release has some work to do to migrate to GTK2 so will take a little time.

Thanks,
Comment 4 Aron Griffis (RETIRED) gentoo-dev 2006-03-24 22:20:02 UTC
Thanks for the patches.  These are in portage now as 0.2.6-r1.  I'm looking forward to the next release.