Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 125116 - media-sound/vorbis-tools-1.1.1-r1: vorbiscomment 1.1.1 can't handle utf-8 comments in utf-8 locale
Summary: media-sound/vorbis-tools-1.1.1-r1: vorbiscomment 1.1.1 can't handle utf-8 com...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High normal
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-05 12:10 UTC by Daniel Schömer
Modified: 2006-03-08 14:13 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
vorbis-tools-1.1.1-utf8.patch (vorbis-tools-1.1.1-utf8.patch,1.28 KB, patch)
2006-03-08 05:58 UTC, Thomas Cort (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Schömer 2006-03-05 12:10:30 UTC
It seems to me that vorbiscomment version 1.1.1 has a bug in handling utf-8 comments under a utf-8 locale. When writting a comment from a utf-8 encoded text file to a ogg-vorbis file, vorbiscomment replaces each two-byte charater in the comments by two '#' characters. Just as if it handles each byte as a 7-bit-ASCII character. Only if I give it the -R parameter both on writing and reading the vorbis comments, the utf-8 characters handled as utf-8 characters.

Version 1.0.1 of vorbiscomment seems to be able to handle utf-8 characters correctly. With this version, it doesn't matter if I give the -R parameter.

(The following commands where executed in an xterm with utf-8 fonts.)

# sudo emerge =vorbis-tools-1.1.1-r1
...
# export LANG=de_DE.UTF-8
# vorbiscomment --version
Vorbiscomment 1.1.1
# cat test.txt
music-by=Esbj
Comment 1 Daniel Schömer 2006-03-05 12:10:30 UTC
It seems to me that vorbiscomment version 1.1.1 has a bug in handling utf-8 comments under a utf-8 locale. When writting a comment from a utf-8 encoded text file to a ogg-vorbis file, vorbiscomment replaces each two-byte charater in the comments by two '#' characters. Just as if it handles each byte as a 7-bit-ASCII character. Only if I give it the -R parameter both on writing and reading the vorbis comments, the utf-8 characters handled as utf-8 characters.

Version 1.0.1 of vorbiscomment seems to be able to handle utf-8 characters correctly. With this version, it doesn't matter if I give the -R parameter.

(The following commands where executed in an xterm with utf-8 fonts.)

# sudo emerge =vorbis-tools-1.1.1-r1
...
# export LANG=de_DE.UTF-8
# vorbiscomment --version
Vorbiscomment 1.1.1
# cat test.txt
music-by=Esbjörn Svenson
# vorbiscomment -w -c test.txt test.ogg ; vorbiscomment -l test.ogg
music-by=Esbj##rn Svenson
# vorbiscomment -R -w -c test.txt test.ogg ; vorbiscomment -l test.ogg
music-by=Esbj?rn Svenson
# vorbiscomment -w -c test.txt test.ogg ; vorbiscomment -R -l test.ogg
music-by=Esbj##rn Svenson
# vorbiscomment -R -w -c test.txt test.ogg ; vorbiscomment -R -l test.ogg
music-by=Esbjörn Svenson

# sudo emerge =vorbis-tools-1.0.1-r1
...
# export LANG=de_DE.UTF-8
# vorbiscomment --version
Vorbiscomment 1.0.1
# cat test.txt
music-by=Esbjörn Svenson
# vorbiscomment -w -c test.txt test.ogg ; vorbiscomment -l test.ogg
music-by=Esbjörn Svenson
# vorbiscomment -R -w -c test.txt test.ogg ; vorbiscomment -l test.ogg
music-by=Esbjörn Svenson
# vorbiscomment -w -c test.txt test.ogg ; vorbiscomment -R -l test.ogg
music-by=Esbjörn Svenson
# vorbiscomment -R -w -c test.txt test.ogg ; vorbiscomment -R -l test.ogg
music-by=Esbjörn Svenson


# emerge --info
Portage 2.0.54 (default-linux/x86/2005.1, gcc-3.3.6, glibc-2.3.5-r2, 2.6.15-gentoo-r1 i686)
=================================================================
System uname: 2.6.15-gentoo-r1 i686 Intel(R) Pentium(R) 4 CPU 2.40GHz
Gentoo Base System version 1.6.14
dev-lang/python:     2.3.5-r2, 2.4.2
sys-apps/sandbox:    1.2.12
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1
sys-devel/binutils:  2.16.1
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.11-r2
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O3 -march=pentium4 -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.4/env /usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config /usr/lib/X11/xkb /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/texmf/web2c /etc/env.d"
CXXFLAGS="-O3 -march=pentium4 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig ccache distlocks fixpackages sandbox sfperms strict suidctl test userpriv usersandbox"
GENTOO_MIRRORS="ftp://ftp.tu-clausthal.de/pub/linux/gentoo/ ftp://pandemonium.tiscali.de/pub/gentoo/"
LINGUAS="en de"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.de.gentoo.org/gentoo-portage"
USE="x86 X a52 aac aalib accounting acl acpi alsa ao apache2 apm asf auctex audiofile avi bash-completion berkdb bitmap-fonts bzip2 cairo calendar cap caps cdda cddb cdparanoia cdr cdrom cracklib crypt css cups curl curlwrappers dbus dnd dri dts dvd dvdr dvdread dvi dynagraph eds emacs emboss encode ethereal exif exim expat fam fame fat fbcon fbdev ffmpeg figlet firefox flac fontconfig foomaticdb fortran ftp gd gdbm gif gimp gkrellm glitz glut glx gmp gnome gnuplot gnutls gpgme gpm graphviz gs gstreamer gtk gtk2 gvim gzip hal hddtemp iconv icq id3 idn ieee1394 imagemagick imap imlib ipv6 javascript jpeg jpeg2k kde lame latex lcms libg++ libwww lirc lm_sensors logrotate mad maildir mailwrapper math mbox md5sum mikmod mime mmap mmx mmxext mng moznocompose moznoirc mozsvg mp3 mpeg mule musicbrainz ncurses nls nntp nptl ntfs ogg oggvorbis opengl opera oss pam pango pcre pdf pdflib perl plugin png pop posix ppds profile python qt quicktime quotas rar readline real recode reiserfs rtc ruby samba sasl screen sdl session sftp sftplogging sharedmem slang slp smime smtp soap sockets sox speex spell sse sse-filters sse2 ssl startup-notification stlport subp subtitles suidcheck svgz symlink sysfs syslog t1lib tcpd tetex text theora thesaurus threads thumbnail tidy tiff transcode truetype truetype-fonts type1 type1-fonts udev unicode usb userlocales utf8 uudeview vfat vim vim-with-x vorbis webdav win32codecs wma wma123 xanim xattr xcomposite xft xine xinerama xinetd xml xml2 xosd xpm xrandr xsl xslt xv zeroconf zlib linguas_en linguas_de userland_GNU kernel_linux elibc_glibc"
Unset:  ASFLAGS, CTARGET, LANG, LC_ALL, LDFLAGS
Comment 2 Thomas Cort (RETIRED) gentoo-dev 2006-03-08 05:58:12 UTC
Created attachment 81680 [details, diff]
vorbis-tools-1.1.1-utf8.patch

This was fixed upstream for Ticket #685.
http://trac.xiph.org/ticket/685

The upstream patch is attached.

I've confirmed that vorbis-tools-1.1.1-r1 has the problem described in this bug and that this patch fixes it.
Comment 3 Alexandre Buisse (RETIRED) gentoo-dev 2006-03-08 14:13:59 UTC
The patch has been added in vorbis-tools-1.1.1-r2.ebuild.

Thanks for the report and the link to upstream patch.