Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 124997 - openoffice-2.0.2_rc4 with fixes
Summary: openoffice-2.0.2_rc4 with fixes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Office Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-04 11:49 UTC by Sheldon Hearn
Modified: 2006-03-04 13:58 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
openoffice-2.0.2_rc4.ebuild (openoffice-2.0.2_rc4.ebuild,7.52 KB, text/plain)
2006-03-04 11:59 UTC, Sheldon Hearn
Details
The build error with USE="firefox -mozilla" (firefox-use-flag-failure.txt,3.34 KB, text/plain)
2006-03-04 13:43 UTC, Sheldon Hearn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sheldon Hearn 2006-03-04 11:49:34 UTC
Here's my ebuild for openoffice-2.0.2_rc4, which includes the following fixes:

1) Fix CFLAGS handling by moving it to before running configure.  Once configure has generated the makefiles, it's messing with the CFLAGS environment variable is a no-op.

2) Fix include paths for the firefox USE flag.

3) Fix LINGUAS handling.  The shell pattern replacement broke for en_ZA. Rather use sed and rest assured that it'll continue to work for new en_?? variants.  Also refresh the list of allowed linguas.
Comment 1 Sheldon Hearn 2006-03-04 11:57:38 UTC
bugzilla's broken at the moment so I can't attach my ebuild.  It's at:

    http://www.starjuice.net/openoffice-2.0.2_rc4.ebuild
Comment 2 Sheldon Hearn 2006-03-04 11:59:06 UTC
Created attachment 81332 [details]
openoffice-2.0.2_rc4.ebuild

No comment.
Comment 3 Andreas Proschofsky (RETIRED) gentoo-dev 2006-03-04 12:26:10 UTC
Just a few comments

(In reply to comment #0)
 
> 1) Fix CFLAGS handling by moving it to before running configure.  Once
> configure has generated the makefiles, it's messing with the CFLAGS environment
> variable is a no-op.

Actually that's a little bit of a misunderstanding, the "real" configure run of OpenOffice.org (which also looks for the CFLAGS) is only called during "make", the first one is only the configure-run of ooo-build. Did you actually have a problem the way it is now, or is this just a guess?
 
> 2) Fix include paths for the firefox USE flag.

What is the problem you are trying to fix with this? It works for me without this (and it should), so that's why I'm asking

> 3) Fix LINGUAS handling.  The shell pattern replacement broke for en_ZA. Rather
> use sed and rest assured that it'll continue to work for new en_?? variants. 
> Also refresh the list of allowed linguas.

Looks definately like a better way to do this, so if you promise me it won't break anything ;) going to add this. A question about your selection of LINGUAS, though: You removed some, put some others in, what did you base your list on?

Anyway: Thanks, always nice to see people looking over the stuff!

Comment 4 Sheldon Hearn 2006-03-04 13:28:02 UTC
(In reply to comment #3)
> Actually that's a little bit of a misunderstanding, the "real" configure run of
> OpenOffice.org (which also looks for the CFLAGS) is only called during "make",
> the first one is only the configure-run of ooo-build. Did you actually have a
> problem the way it is now, or is this just a guess?

Just a guess.  All I actually needed was the append-flags, and then saw that my -O3 had made it past the filter-flags into generated makefiles, so I moved the CFLAGS manipulation.

> > 2) Fix include paths for the firefox USE flag.
> 
> What is the problem you are trying to fix with this? It works for me without
> this (and it should), so that's why I'm asking

I'll attach the build failure I got, sorry.

> Looks definately like a better way to do this, so if you promise me it won't
> break anything ;) going to add this. A question about your selection of
> LINGUAS, though: You removed some, put some others in, what did you base your
> list on?

The contents of the po subdirectory.

> Anyway: Thanks, always nice to see people looking over the stuff!

I'm guessing OpenOffice.org package maintenance is a very lonely job. :-)
Comment 5 Sheldon Hearn 2006-03-04 13:43:49 UTC
Created attachment 81349 [details]
The build error with USE="firefox -mozilla"
Comment 6 Sheldon Hearn 2006-03-04 13:46:04 UTC
I should have mentioned that my USE flags that tickled the missing header problem were:

-binfilter +curl -eds +firefox -gnome +gtk +java +kde +ldap -mozilla +xml2
Comment 7 Andreas Proschofsky (RETIRED) gentoo-dev 2006-03-04 13:58:26 UTC
(In reply to comment #5)
> Created an attachment (id=81349) [edit]
> The build error with USE="firefox -mozilla"
> 

That was another bug with -mozilla, see here:

https://bugs.gentoo.org/show_bug.cgi?id=124540

This is already fixed in the portage rc4 (which is based on ooo-build-oob680.5.0 while your ebuild is based on an older ooo-build-release), so no need for that hack.

Rest of the fixes I've alredy applied to the ebuild, so closing this, thanks again.