Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 124991 - net-analyzer/scanlogd uses CLK_TCK not CLOCKS_PER_SEC
Summary: net-analyzer/scanlogd uses CLK_TCK not CLOCKS_PER_SEC
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Netmon project
URL: http://forums.gentoo.org/viewtopic.ph...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-04 10:55 UTC by Beech Horn
Modified: 2006-03-26 15:06 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
scanlogd-2.2.5-r1.ebuild (scanlogd-2.2.5-r1.ebuild,932 bytes, text/plain)
2006-03-04 10:55 UTC, Beech Horn
Details
clk_tck_to_clocks_per_sec_params.h.patch (clk_tck_to_clocks_per_sec_params.h.patch,751 bytes, patch)
2006-03-04 10:56 UTC, Beech Horn
Details | Diff
scanlogd-2.2.6.ebuild (scanlogd-2.2.6.ebuild,868 bytes, text/plain)
2006-03-06 10:20 UTC, Beech Horn
Details
scanlogd-2.2.6.ebuild (scanlogd-2.2.6.ebuild,888 bytes, text/plain)
2006-03-11 04:13 UTC, Beech Horn
Details
scanlogd-2.2.6-custom-cflags.patch (scanlogd-2.2.6-custom-cflags.patch,316 bytes, patch)
2006-03-15 18:13 UTC, Beech Horn
Details | Diff
scanlogd-2.2.6-r1.ebuild (scanlogd-2.2.6-r1.ebuild,998 bytes, text/plain)
2006-03-15 18:14 UTC, Beech Horn
Details
scanlogd-2.2.6-pexit.patch (scanlogd-2.2.6-pexit.patch,474 bytes, patch)
2006-03-15 18:26 UTC, Beech Horn
Details | Diff
scanlogd-2.2.6-r2.ebuild (scanlogd-2.2.6-r2.ebuild,1.01 KB, text/plain)
2006-03-15 18:27 UTC, Beech Horn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Beech Horn 2006-03-04 10:55:14 UTC
New ebuild and patch to resolve the issue.
Comment 1 Beech Horn 2006-03-04 10:55:44 UTC
Created attachment 81324 [details]
scanlogd-2.2.5-r1.ebuild
Comment 2 Beech Horn 2006-03-04 10:56:01 UTC
Created attachment 81325 [details, diff]
clk_tck_to_clocks_per_sec_params.h.patch
Comment 3 Marcelo Goes (RETIRED) gentoo-dev 2006-03-04 12:25:31 UTC
Hi,

I am not familiar with this issue, can you point out why this modification is necessary? It does compile for me as it is with gcc-4.1.

I also recommend sending this patch to upstream so that they can check it out.

Cheers,
Marcelo
Comment 4 Beech Horn 2006-03-04 12:31:13 UTC
From the forum link:

metalshark wrote:
Just for the record - the issues I get for the official ebuild when compiling programs all mention CLK_TCK - for instance:

Code:
grab_partial_image.c: In function 
Comment 5 Beech Horn 2006-03-04 12:31:13 UTC
From the forum link:

metalshark wrote:
Just for the record - the issues I get for the official ebuild when compiling programs all mention CLK_TCK - for instance:

Code:
grab_partial_image.c: In function main:
grab_partial_image.c:239: error: CLK_TCK undeclared (first use in this function)
grab_partial_image.c:239: error: (Each undeclared identifier is reported only once
grab_partial_image.c:239: error: for each function it appears in.)
make[2]: *** [grab_partial_image.o] Error 1

media-libs/libdc1394-2.0.0_pre5-r1


I use ntp-client so the clock is correct (even phoned 123 - the talking clock - just to check), have no idea what on earth it's on about though, CLK_TCK?!?


You need to edit the file that CLK_TCK is in and change that to CLOCKS_PER_SEC

Then do: FEATUERS="keepwork" emerge {packagename}
or write a patch for it. CLK_TCK has been obsoleted by the C++ specifications, so even on M$, you need to change that. :P Just for reference.

-------------------------------------------------------------------------------

The params.h in scanlogd uses CLK_TCK - I've just edited it to use ClOCKS_PER_SEC
Comment 6 Beech Horn 2006-03-04 12:50:57 UTC
I cannot find ANYWHERE on www.openwall.com to submit this patch...
Comment 7 Marcelo Goes (RETIRED) gentoo-dev 2006-03-04 13:13:55 UTC
I just emerged both scanlogd and libdc1394 with gcc-4.1 and the same problem did not crop up for me. :-(

From scanlogd.spec:
You may want to contact Solar Designer <solar at owl dot openwall dot com> (entry is from mid-2004, so I don't know if upstream is alive, but it doesn't hurt to try).
Comment 8 Beech Horn 2006-03-04 13:24:09 UTC
Thanks for the email address - just sent an email to Solar. Well I've looked up CLK_TCK and is definitely is OBSOLETE - I am running bleeding edge and run into issues early. This will affect everyone who moves to GLIBC 2.4 next week - so unless it gets out soon expect nothing but duplicate bug reports. It's a GLIBC 2.3.9/2.4 issue - GCC-4.1.0 is a misnomer. Hence I added the WHOLE forum posting...
Comment 9 Beech Horn 2006-03-04 13:26:45 UTC
I am yet to actually submit a valid fix to Gentoo (look at all my bug reports) and get them added - yet help people on the forums and over Instant Messengers by giving my overlays. Is there any point in submitting bugs to Gentoo - I just hit a brick wall everytime and am loosing patience.
Comment 10 Marcelo Goes (RETIRED) gentoo-dev 2006-03-04 13:44:22 UTC
Please, relax. I did not say I was not going to add your fix - I just wanted to know more about it. This is done because 1) I need to KNOW what I am doing, 2) I need to TEST the fix and 3) LEARNING for similar bugs. Most developers are not running bleeding edge glibc since we need stable systems to test everything else. Because of this, I could not do 1 or 2.

We are more than willing to review and commit your fixes, but first we have to know what on Earth they are meant to be fixing. Ok?
Comment 11 Beech Horn 2006-03-04 14:16:45 UTC
Ok, I thought the post from the forum was clear - and had pretty much come to the end of my teather (actually I think I did). Everyone says to keep submitting bugs - but when you are told they are non-existant or get fixed in the same way by a dev days later (duplicated efforts) you start to loose your nerve. I worked for many years on contributing to Slackware, where fixes are accepted almost instantly and the people reviewing bugs seem to know more about them than the contributors. This is just such a frustrating Gnome dev style culture shock. Gnome devs have recently been questioned by Linus about being "interface nazis" but I think what he was on about more was the development practice. I only find this style of bug rejection within Gentoo/Gnome - not Slackware/KDE - and I for one REALLY think something needs done about it. Gentoo is the best distribution for all my varied systems to date - but the contribution system really knows how to wind me up.
Comment 12 Beech Horn 2006-03-04 14:28:48 UTC
The irony with the GLIBC statement is that both the CVS GLIBC is very stable at the minute - it's soon going to be 2.4 - nxsty is having to maintain the GLIBC overlay and is doing a great job.
Comment 13 Marcelo Goes (RETIRED) gentoo-dev 2006-03-04 15:25:14 UTC
I do not maintain glibc, I do not run glibc from cvs and quite frankly I am sorry I took an interest in this bug so that you can keep insulting me because I asked you what the problem was. You are your own brickwall.

glibc from cvs is not part of Gentoo and therefore not supported. You did a good job at making me not care, too. Reopen when glibc-2.4 hits Portage.

Also, I recommend you stop reporting bugs about software that is not in the tree altogether - it will save a lot of frustation from your side and ours.
Comment 14 Beech Horn 2006-03-05 05:10:20 UTC
Deal.
Comment 15 Beech Horn 2006-03-06 04:57:06 UTC
This patch (more like hack) is flawed as it breaks backwards compatiblity. Solar informed me aswell.

It was never a direct attack against Marcelo Goes.

I was the one lacking information.

Openwall are working on this issue so expect problems to be resolved upstream instead (as originally adviced).
Comment 16 Beech Horn 2006-03-06 10:20:57 UTC
Created attachment 81541 [details]
scanlogd-2.2.6.ebuild

This is an -rc ebuild that compiles without patches - TEST RELEASE ONLY!!! Don't think Solar would appreciate bug reports yet :p
Comment 17 Beech Horn 2006-03-06 10:37:20 UTC
PLEASE DON'T USE THE LATEST EBUILD!!!

Solar asked me to pull it as he wants to release the new Openwall software first and the link to the tarball will die soon. Expect a new Openwall software suite with GLIBC 2.4 support really soon - so all probs will be fixed upstream - whoever is maintaining the ebuilds can always ask for help with version bumped editions as soon as it's released - will just put them in an overlay and link here if they aren't done by the time I get round to it.
Comment 18 Beech Horn 2006-03-11 04:13:10 UTC
Created attachment 81910 [details]
scanlogd-2.2.6.ebuild

Solar has now officially released the new version.
Comment 19 Beech Horn 2006-03-11 04:13:48 UTC
Valid ebuild and released upstream version.
Comment 20 Marcelo Goes (RETIRED) gentoo-dev 2006-03-11 10:03:52 UTC
Thanks, bumped in cvs.
There was no need for RESTRICT="primaryuri" in the ebuild AFAIK, so I removed it.

Cheers!
Comment 21 Beech Horn 2006-03-12 10:40:13 UTC
RESTRICT="primaryuri"

justs removes GENTOO_MIRRORS from working (needed to get the new version from the net.
Comment 22 Marcelo Goes (RETIRED) gentoo-dev 2006-03-12 11:03:22 UTC
It will propagate through our mirrors automagically. That restriction is for stuff that we are not allowed to mirror.
Comment 23 Beech Horn 2006-03-12 11:13:33 UTC
Depends on how long your GENTOO_MIRRORS is - I use overlays form myself and friends so my custom ebuilds often say it - you're right to remove it though.
Comment 24 Beech Horn 2006-03-15 18:13:05 UTC
Created attachment 82254 [details, diff]
scanlogd-2.2.6-custom-cflags.patch

Allows the setting of C/LD FLAGS in the make.conf to propagate.
Comment 25 Beech Horn 2006-03-15 18:14:38 UTC
Created attachment 82255 [details]
scanlogd-2.2.6-r1.ebuild

An ebuild using the new patch with an IUSE="custom-cflags" and the patch application in src_unpack with an if statement.
Comment 26 Beech Horn 2006-03-15 18:15:31 UTC
Addition of custom-cflags.
Comment 27 Beech Horn 2006-03-15 18:26:01 UTC
Created attachment 82257 [details, diff]
scanlogd-2.2.6-pexit.patch

It shouldn't be returning pexit inside a void function.
Comment 28 Beech Horn 2006-03-15 18:27:02 UTC
Created attachment 82258 [details]
scanlogd-2.2.6-r2.ebuild

New ebuild with new patch.
Comment 29 Markus Ullmann (RETIRED) gentoo-dev 2006-03-26 15:06:48 UTC
Thanks, user CFLAGS/LDFLAGS are now respected. The other patch should be sent upstream as it isn't Gentoo related.