Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 124907 - media-gfx/splashutils: print einfos only when neccessary
Summary: media-gfx/splashutils: print einfos only when neccessary
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Michal Januszewski (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-04 01:02 UTC by Paweł Hajdan, Jr. (RETIRED)
Modified: 2006-03-14 09:09 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
splashutils.patch (splashutils.patch,1.85 KB, patch)
2006-03-04 01:03 UTC, Paweł Hajdan, Jr. (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2006-03-04 01:02:26 UTC
There are some ewarns/einfos in the splashutils ebuilds that may not be neccessary in all cases:

- info about upgrade from pre-1.0 version should be printed only when user upgrades from such version
- info about adding 'console=tty1' to kernel command line should be printed only when it is not present in current kernel command line
- information about seperate themes should be printed only when there is no theme installed (in my opinion)
Comment 1 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2006-03-04 01:03:52 UTC
Created attachment 81271 [details, diff]
splashutils.patch

ebuild patch (may work for older ebuilds too)
Comment 2 Marius Mauch (RETIRED) gentoo-dev 2006-03-04 01:12:57 UTC
For the record: you can't use has_version in postinst to determine the old version as it may not be present anymore.
Comment 3 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2006-03-04 01:42:28 UTC
(In reply to comment #2)
> For the record: you can't use has_version in postinst to determine the old
> version as it may not be present anymore.

According to http://dev.gentoo.org/~plasmaroo/devmanual//ebuild-writing/functions/pkg_postinst/ it is possible:

"The most common use for pkg_postinst is to display post-install informational messages or warnings. Note that has_version will operate on the version that was installed, which can be useful for selective upgrade messages."
Comment 4 Michal Januszewski (RETIRED) gentoo-dev 2006-03-14 09:09:33 UTC
Added to CVS, thanks for the suggestion and the patch :)

I left the has_version stuff in place as it seems to work just fine.