Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 124565 - sarab-0.2.2-r1 can incorrectly identify the reference backup
Summary: sarab-0.2.2-r1 can incorrectly identify the reference backup
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: x86 Linux
: Normal normal (vote)
Assignee: Matthew Kennedy (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-01 13:34 UTC by Rob Grady
Modified: 2006-03-03 10:18 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to correctly identify reference archive (0.2.2-fix-reference-gentoo.patch,889 bytes, patch)
2006-03-01 13:36 UTC, Rob Grady
Details | Diff
0.2.2-refname-calculation-gentoo.patch (0.2.2-refname-calculation-gentoo.patch,890 bytes, patch)
2006-03-02 08:45 UTC, Matthew Kennedy (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Grady 2006-03-01 13:34:59 UTC
When attempting an incremental backup, sarab can fail when it does not find the reference backup.  This occurs because the code to identify the reference backup does not account for having periods in the path or filename (ie.: /mnt/backup/.archive).  A patch was created on the Sarab page on Sourceforge (http://sourceforge.net/tracker/index.php?func=detail&aid=1381136&group_id=91804&atid=598443) that contains the fix in the attached patch file.
Comment 1 Rob Grady 2006-03-01 13:36:59 UTC
Created attachment 81068 [details, diff]
patch to correctly identify reference archive
Comment 2 Matthew Kennedy (RETIRED) gentoo-dev 2006-03-02 08:43:44 UTC
Thanks for the note.  This looks like a good fix to have.  I've changed the patch you attached to use sed rather than perl.  Please check it over and then I'll commit it to CVS.
Comment 3 Matthew Kennedy (RETIRED) gentoo-dev 2006-03-02 08:45:36 UTC
Created attachment 81117 [details, diff]
0.2.2-refname-calculation-gentoo.patch

replaces perl call with sed
Comment 4 Rob Grady 2006-03-03 07:09:08 UTC
That looks great to me.
Comment 5 Matthew Kennedy (RETIRED) gentoo-dev 2006-03-03 10:18:21 UTC
Committed to CVS, thanks for the bug report.