Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 124451 - Subversion eclass' subversion_src_unpack() function unpacks things from ${A}
Summary: Subversion eclass' subversion_src_unpack() function unpacks things from ${A}
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Low minor (vote)
Assignee: Akinori Hattori
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-28 12:04 UTC by Michael Schmid
Modified: 2006-03-20 07:02 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Schmid 2006-02-28 12:04:04 UTC
In subversion.eclass, function subversion_src_unpack() there is these three lines of code (lines number 246 to 248):

       if [ -n "${A}" ]; then
               unpack ${A}
       fi

This makes it harder to override the default behaviour of src_unpack() in an ebuild when using this eclass. You would have to reimplement the subversion_src_unpack() function without these lines in src_unpack() or set ${A} to a zero-length string. The latter is prohibited tho, according to the ebuild HOWTO.

I think that these lines should be deleted, or at least supplemented by a flag variable that allows to disable this part of the code. The earlier variant should be better, since the behaviour is consistent with the more frequently used cvs.eclass and doesn't duplicate functionality in the wrong place.
Comment 1 Akinori Hattori gentoo-dev 2006-03-20 07:02:39 UTC
Fixed in CVS. (removed line: 246-248). Thank you for reporting.