Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 124319 - www-client/seamonky QA issues
Summary: www-client/seamonky QA issues
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-27 16:12 UTC by Ciaran McCreesh
Modified: 2006-05-20 11:17 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ciaran McCreesh 2006-02-27 16:12:22 UTC 
From seamonkey-1.0.ebuild:

    =www-client/mozilla-launcher-1.47

Any reason this can't use ~ ?

    pkg_setup() {
    if ! use moznoirc && use moznocompose; then

No indenting?

    sleep 10

(several times) Ebuilds aren't allowed to call sleep directly. This should be replaced by epause from eutils.eclass. Also, is there really any need to sleep between messages, rather than only sleeping at most once?
Comment 1 Mark Loeser (RETIRED) gentoo-dev 2006-05-19 22:04:51 UTC 
mozilla team:  can you please address these minor issues?  Thanks.
Comment 2 Jory A. Pratt 2006-05-19 23:30:23 UTC 
They will be addressed in next release.
Comment 3 Jory A. Pratt 2006-05-20 11:17:14 UTC 
all these issues have already been addressed, the ewarns will change as some of them are invalid in upcoming release but all QA issues other then that addressed.