Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 124181 - Minor change to DISTDIR, PKGDIR, and RPMDIR in make.globals.
Summary: Minor change to DISTDIR, PKGDIR, and RPMDIR in make.globals.
Status: RESOLVED CANTFIX
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Enhancement/Feature Requests (show other bugs)
Hardware: All Other
: High normal
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-26 10:33 UTC by Jon
Modified: 2006-02-28 08:04 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jon 2006-02-26 10:33:09 UTC
Hi,

I decided to put portage on a different drive so I maped that drive to /portage, and wanted the main gentoo tree in /portage/gentoo and then the overlay at /portage/overlay.

I made the change in make.conf, but the the other directories were not changed. The three directories I have listed in the summery are hard coded to /usr/portage. Should "/usr/portage" be replaced with "${PORTDIR}", and then add a warning to make.conf that if you change the location of the portage tree, the loaction for those directories will change as well? That way all those directories do not need to be overridden in make.conf.

Just a thought.
Comment 1 Marius Mauch (RETIRED) gentoo-dev 2006-02-26 15:42:03 UTC
This is a bit confusing ... where exactly should what be changed?
(I have a guess what you mean, but don't want to close this as CANTFIX incorrectly if I'm wrong).
Comment 2 Jon 2006-02-26 17:03:48 UTC
Oh, sorry for the confussion. Explaining things isn't one of my best areas. *turns red*

Okay, in the file /etc/make.globals in the part labeled "# Repository Paths" these directories are defined:
PORTDIR=/usr/portage
DISTDIR=/usr/portage/distfiles
PKGDIR=/usr/portage/packages
RPMDIR=/usr/portage/rpm

If one were to override the PORTDIR in /etc/make.conf, then all the other directories need to be changed as well otherwise they still point to /usr/portage. However, I have a separate partition that I made for the portage tree and I want both Gentoo and the overlay on that partition. I mounted the partition at /portage. The gentoo portage tree is at /portage/gentoo. I moved my distfiles directory to this new directory thinking it would be used, but I went to reinstall something and it had to DL it again and it DLed it to /usr/portage/distfiles.

I read the example file at /etc/make.conf.example and it showed an example of setting the distfiles directory as:
DISTDIR=${PORTDIR}/distfiles
This is why I thought that by moving my distfiles directory to the new Portage Directory, it would be used.

So, I propose that in /etc/make.globals, the lines:
DISTDIR=/usr/portage/distfiles
PKGDIR=/usr/portage/packages
RPMDIR=/usr/portage/rpm

Are changed to:
DISTDIR=${PORTDIR}/distfiles
PKGDIR=${PORTDIR}/packages
RPMDIR=${PORTDIR}/rpm

This way, if a user overrides PORTDIR, then all the other directories will change as well. This should be normal and expected behavior because people are use to the distfiles directory being where PORTDIR is defined. Also, the way it's worded in the example make.conf, it seems as though this is normalbehavior as well, because the examples use ${PORTDIR}, which indicates that the directory should be in the main portage directory.

Is this more clear? If not, let me know. :) I will try to do better next time. Again, sorry about the lack of clarity.

Jon
Comment 3 Marius Mauch (RETIRED) gentoo-dev 2006-02-28 08:04:26 UTC
Ok, it's as I assumed. While we could of course change the definitions in make.globals it wouldn't help anything, because at the time you redefine $PORTDIR the definitions in make.globals have already been expanded with the old value defined in make.globals.