Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 124118 - transcode import_mplayer library is broken
Summary: transcode import_mplayer library is broken
Status: RESOLVED NEEDINFO
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-25 18:49 UTC by Fati
Modified: 2006-06-26 16:25 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fati 2006-02-25 18:49:40 UTC
The import_mplayer module compiled with the latest stable version of transcode(0.6.14-r3) is currently incompatible with the latest stable version of mplayer 1.0.20060217 .  The problem lies in when the library attempts to call mplayer and output to a named pipe, but uses deprecated command line options.  Because of the bad command line options, mplayer fails and transcode hangs indefinitely until manually killed.  Here is a diff to fix the command line option, though it would be nice if transcode detected the failing mplayer and properly errored out with it too!

diff -u -r transcode-0.6.14-orig/import/import_mplayer.c transcode-0.6.14/import/import_mplayer.c
--- transcode-0.6.14-orig/import/import_mplayer.c       2004-11-02 23:46:13.000000000 -0500
+++ transcode-0.6.14/import/import_mplayer.c    2006-02-25 17:54:39.000000000 -0500
@@ -125,7 +125,7 @@
         return(TC_IMPORT_ERROR);
       }
       
-      if (snprintf(import_cmd_buf, MAX_BUF, "mplayer -hardframedrop -vo null -ao pcm -nowaveheader -aofile %s %s \"%s\" > /dev/null 2>&1",
+      if (snprintf(import_cmd_buf, MAX_BUF, "mplayer -hardframedrop -vo null -ao pcm:nowaveheader -aofile:file=%s %s \"%s\" > /dev/null 2>&1",
           audiopipe, ((vob->im_a_string)?vob->im_a_string:""), vob->audio_in_file) < 0) {
         perror("command buffer overflow");
                unlink(audiopipe);

***emerge --info***
Portage 2.0.54 (default-linux/x86/2005.1, gcc-3.3.6, glibc-2.3.5-r2, 2.6.15-gentoo-r1 i686)
=================================================================
System uname: 2.6.15-gentoo-r1 i686 Intel(R) Pentium(R) 4 CPU 3.20GHz
Gentoo Base System version 1.6.14
dev-lang/python:     2.3.5, 2.4.2
sys-apps/sandbox:    1.2.12
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1
sys-devel/binutils:  2.16.1
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.11-r2
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=pentium4"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.4/env /usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config /usr/lib/X11/xkb /usr/lib/mozilla/defaults/pref /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -march=pentium4"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig distlocks sandbox sfperms strict"
GENTOO_MIRRORS="ftp://ftp.gtlib.cc.gatech.edu/pub/gentoo http://gentoo.chem.wisc.edu/gentoo/ ftp://gentoo.mirrors.pair.com/"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.us.gentoo.org/gentoo-portage"
USE="x86 X a52 acpi aim alsa apm arts audiofile avi berkdb bitmap-fonts bzip2 calendar cdparanoia cdr crypt cups curl dri dvd dvdr dvdread eds emboss encode esd ethereal exif expat fam fbcon ffmpeg fftw foomaticdb fortran ftp gdbm gif glut gmp gphoto2 gpm gstreamer gtk gtk2 idn imagemagick imlib ipv6 jabber jack java jpeg lcms libg++ libwww mad maildir mikmod mime mjpeg mng motif mozilla mp3 mpeg ncurses nls nsplugin ogg oggvorbis opengl oss pam pcre pdflib perl png ppds python qt quicktime readline samba sdl sndfile sockets sox spell sse ssl tcpd tiff truetype truetype-fonts type1-fonts udev usb vcd videos vorbis win32codecs wxwindows xine xml2 xmms xpm xv xvid yahoo zlib userland_GNU kernel_linux elibc_glibc"
Unset:  ASFLAGS, CTARGET, LANG, LC_ALL, LDFLAGS, LINGUAS
Comment 1 Old Hobb 2006-04-07 21:17:13 UTC
So the above patch is mostly correct, but -aofile has also been depricated, instead add it to the pcm line; such as:

+      if (snprintf(import_cmd_buf, MAX_BUF, "mplayer -hardframedrop -vo null -ao pcm:nowaveheader:file=%s %s \"%s\" > /dev/null 2>&1",

Comment 2 Steve Dibb (RETIRED) gentoo-dev 2006-06-26 16:25:08 UTC
Cleaning out old bugs, transcode 0.6 is out of portage now, but reopen if still an issue with stable versions of transcode (1.0.2) and mplayer (1.0_pre8)

Thanks Fati