Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 123977 - smb4k-0.6.8 (package update)
Summary: smb4k-0.6.8 (package update)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo KDE team
URL: http://kde-apps.org/content/show.php?...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-24 13:01 UTC by Przemyslaw Maciag (RETIRED)
Modified: 2006-02-26 07:38 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Przemyslaw Maciag (RETIRED) gentoo-dev 2006-02-24 13:01:37 UTC
Simple package update.

Regards,
Przemek
Comment 1 Przemyslaw Maciag (RETIRED) gentoo-dev 2006-02-24 14:06:28 UTC
old ebuild works without problems...

just one question. as I see al langpacks are being install. why? I don't need them :/

It would be better to change this to install only needed langpacks according to LINGUAS var. Hmm... Maybe a good idea would be to put it into some kde eclass as common function?

Regards,
Przemek
Comment 2 Carsten Lohrke (RETIRED) gentoo-dev 2006-02-26 04:48:28 UTC
The question isn't so much, if you need the 0.5 MB of translations, but if its worth increasing the time a maintainer spends with a simple version bump. Unfortunately it's not possible to find out automatically for which languages translations exist in a reliable way.
Comment 3 Przemyslaw Maciag (RETIRED) gentoo-dev 2006-02-26 05:16:55 UTC
(In reply to comment #2)
> The question isn't so much, if you need the 0.5 MB of translations, but if its
> worth increasing the time a maintainer spends with a simple version bump.
It's not only 0.5 MB. This is 0.5 MB of this package, than another package, and another.... It's not a 'big problem', but it could be done quite easy (imho).

> Unfortunately it's not possible to find out automatically for which languages
> translations exist in a reliable way.
First solution:
Translations are keeped in po directory, where we can find Makefile for creating and install them. Few vars from Makefile.in has info about all translation:

POFILES = zh_CN.po zh_TW.po bg.po ca.po da.po de.po cs.po es.po fr.po hu.po ja.po is.po it.po nb.po nl.po nn.po pl.po ru.po sk.po sv.po tr.po uk.po pt_BR.po
GMOFILES = zh_CN.gmo zh_TW.gmo bg.gmo ca.gmo da.gmo de.gmo cs.gmo es.gmo fr.gmo hu.gmo ja.gmo is.gmo it.gmo nb.gmo nl.gmo nn.gmo pl.gmo ru.gmo sk.gmo sv.gmo tr.gmo uk.gmo pt_BR.gmo
KDE_DIST=tr.gmo zh_CN.po nl.po sv.gmo zh_TW.gmo pl.gmo uk.gmo nn.po bg.gmo ru.po da.po ru.gmo is.po nb.gmo uk.po de.po fr.gmo ja.gmo nb.po fr.po ca.po cs.po zh_CN.gmo tr.po sk.gmo zh_TW.po cs.gmo pt_BR.gmo nn.gmo Makefile.in is.gmo bg.po pt_BR.po ja.po it.gmo sv.po hu.po pl.po de.gmo es.po es.gmo it.po sk.po nl.gmo hu.gmo ca.gmo da.gmo Makefile.am
pl.gmo: pl.po

From my point of view (but I could be wrong in this...) this (installing only needed lang files) could be done by easy seding it.

Second solution (not so nice, but easier):
In src_install (kde_src_install ? ) we could use single 'for' loop to determine which translations user wants to install and which ones he don't wants.

Something like:
mkdir -p ${WORKDIR}/etranslations
mv ${D}/usr/share/locale/* ${WORKDIR}/etranslations
for i in ${LINGUAS}; do
    if [ -d ${WORKDIR}/etranslations/${i} ]; then
        mv ${WORKDIR}/etranslations/${i} ${D}/usr/share/locale
    fi;
done;

what should install only chosen languages...

First solution is a bit tricky, cause it may fail if translation directory is something different than 'po', but this could be done by setting var TRANSLATIONS_DIRECTORY, or something like that.

Well... it's just my 0.02 cents :)

Regards,
Przemek
Comment 4 Carsten Lohrke (RETIRED) gentoo-dev 2006-02-26 07:38:16 UTC
(In reply to comment #3)
> (In reply to comment #2)
> It's not only 0.5 MB. This is 0.5 MB of this package, than another package, and
> another.... It's not a 'big problem', but it could be done quite easy (imho).
>

See the latest digikam ebuild, why it's not that simple in every case. In general I really don't care that much for the few dozens MB of localizations by a bunch of packages. You can always run a cron script cleaning out /usr/share/locale periodically.