Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 123899 - mutt-1.5.15 - sidebar patch
Summary: mutt-1.5.15 - sidebar patch
Status: RESOLVED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: Fernando J. Pereda (RETIRED)
URL: http://www.lunar-linux.org/index.php?...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-24 01:13 UTC by Piotr Szymaniak
Modified: 2007-04-09 21:34 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
POOR mutt-sidebar/mutt-sidebar-1.5.11.ebuild (mutt-sidebar-1.5.11.ebuild,1.27 KB, text/plain)
2006-02-24 01:17 UTC, Piotr Szymaniak
Details
mutt-1.5.13-r1.ebuild with optional sidebar support (mutt-1.5.13-r1.ebuild,4.33 KB, text/plain)
2006-12-20 00:06 UTC, Patrik Kullman
Details
mutt-1.5.13-sidebar.20061023.patch (mutt-1.5.13-sidebar.20061023.patch,49.96 KB, patch)
2006-12-20 00:07 UTC, Patrik Kullman
Details | Diff
mutt-1.5.14-r1.ebuild with USE=sidebar and nntp conflict detection (mutt-1.5.14-r1.ebuild,4.50 KB, text/plain)
2007-03-22 15:02 UTC, Tim Weber
Details
mutt-1.5.14-sidebar.patch (mutt-1.5.14-sidebar.patch,49.78 KB, text/plain)
2007-03-22 15:05 UTC, Tim Weber
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Szymaniak 2006-02-24 01:13:49 UTC
As in the "Features" section:
- A sidebar with a list of folders on the left side of the mutt window.
- Hide/Unhide the sidebar with a single keystroke.
- Every line in the sidebar lists a folder with the total and new number of messages in it.
- Optionally highlight folders with new messages.
- Scroll up and down the list of folders and open the selected folder.
- Configurable sidebar width and colors.
- Configurable key bindings.
Comment 1 Piotr Szymaniak 2006-02-24 01:17:15 UTC
Created attachment 80579 [details]
POOR mutt-sidebar/mutt-sidebar-1.5.11.ebuild

My poor ebuild for this, and it is only an edit of this: http://www.gentoo.pl/~arsen/packs/mutt-sidebar-1.5.9.tar.gz (also a poor ebuild ;)
Comment 2 Patrik Kullman 2006-12-19 06:27:11 UTC
I guess the information in this bug isn't really relevant anymore?

My proposed solution is to have a USE="sidebar" in the original mutt ebuild and use the patch from http://lunar-linux.org/~tchan/mutt/patch-1.5.13.sidebar.20061023.txt

It would be really sweet to have the sidebar, though..
Comment 3 Patrik Kullman 2006-12-20 00:06:23 UTC
Created attachment 104421 [details]
mutt-1.5.13-r1.ebuild with optional sidebar support

This is an ebuild that patches the current x86 ebuild of mutt with optional sidebar support.

Sidebar patch taken from http://lunar-linux.org/index.php?page=mutt-sidebar
Comment 4 Patrik Kullman 2006-12-20 00:07:07 UTC
Created attachment 104422 [details, diff]
mutt-1.5.13-sidebar.20061023.patch

The patch itself
Comment 5 Fernando J. Pereda (RETIRED) gentoo-dev 2006-12-20 04:39:11 UTC
That has to be worked out a bit more. The sidebar patch does NOT work with the nntp patch.

I just applied it on top of our patchset and made it apply cleanly. However it is a suboptimal solution given the fact that the nntp and sidebar patches conflict both code and feature wise.

- ferdy
Comment 6 Patrik Kullman 2006-12-20 04:48:01 UTC
Can't this be solved like other ebuilds by spitting out an error if both use-flags are on and exiting with a message to the user to disable one of them?

Or to print a warning saying sidebar support is disabled since the nntp use-flag is on and they can't co-exist?

It's working perfectly with my setup (USE="berkdb crypt gdbm idn imap nls sasl sidebar ssl") and I wouldn't trade it for nntp.. ;)
Comment 7 Tim Weber 2007-03-22 15:02:23 UTC
Created attachment 114055 [details]
mutt-1.5.14-r1.ebuild with USE=sidebar and nntp conflict detection

Since I'm starting to use mutt again and mutt-ng development has ceased, I took the effort to update sidebar support for Gentoo's mutt to 1.5.14. This new ebuild is based on the .14 one, but contains a new "sidebar" USE flag that will activate the sidebar patch (after all other patches). If both the sidebar and nntp flags are set, the script will die (using confutils_use_conflict from the confutils eclass). I also made some minor cleanup changes to the .14 ebuild (indentation and configure switches order).

I'll post the updated patch (unmodified from upstream http://lunar-linux.org/index.php?page=mutt-sidebar) for .14 in a second.
Comment 8 Tim Weber 2007-03-22 15:05:50 UTC
Created attachment 114057 [details]
mutt-1.5.14-sidebar.patch

The actual patch. Applies cleanly after the 01-06 chain from the Gentoo patches tarball and could be included there. You would then need to modify the ebuild to _remove_ the patch if the sidebar is not used (like the nntp USE flag already does with its patch).
Comment 9 Fernando J. Pereda (RETIRED) gentoo-dev 2007-03-22 15:22:31 UTC
I will try to integrate said patch on a revbump soon.

- ferdy
Comment 10 Fernando J. Pereda (RETIRED) gentoo-dev 2007-04-06 22:31:40 UTC
Ok, mutt-1.5.15 is here. This patch _will_ be part of our patchset for said version.

Thanks guys, and sorry for not having it ready earlier.

- ferdy
Comment 11 Fernando J. Pereda (RETIRED) gentoo-dev 2007-04-09 21:34:29 UTC
It should be all set. Please test mutt-1.5.15 with USE="-vanilla" it should pull the sidebar patch with it.

Until the mirrors propagate, you can (manually) get mutt-1.5.15-gentoo-patches.tar.bz2 from http://dev.gentoo.org/~ferdy/distfiles

Enjoy it and let me know if it fails !

- ferdy