NetBSD has no such stpcpy function. I created a patch to fix this on systems that have no stpcpy. The patch must be applied after all the patches (especially after cpio-2.6-writeOutHeaderBufferOverflow.patch from #112140).
Created attachment 80068 [details, diff] cpio-2.6-bsd.patch There goes the patch.
Compiled on DragonFly with this patch. Failed without it.
On OpenBSD too, base-system, please apply this patch.
Going to commit in overlay in the mean time. Oh it needs an AT_M4DIR="m4" eautoreconf as it changes configure.ac, but it works otherwise. Benigno, did you send it to upstream already?
Yes, I just sent him a notification of this patch and the one from #112140, because this patch depends on cpio-2.6-writeOutHeaderBufferOverflow.patch. Thanks for adding it.
i dont think that's the right fix at all cpio already has a lib subdir for functions that the host doesnt support, you should be putting stpcpy.c in there like the other stuff and then updating AC_REPLACE_FUNCS
Uh that's gnulib stuff... it's quite difficult to patch it out, this solution works with the least changes. And it's already fixed upstream in next version.
i wasnt talking about the source tarball but about the upstream repo ... the patch posted is not correct for upstream but they've committed a fix upstream that involves pulling in stpcpy from gnulib
This replacing is not wrong. If this stpcpy implementation used by gnulib is something like this, I would say that this patch "cpio-2.6-bsd.patch" is better than it: http://cvs.savannah.nongnu.org/viewcvs/bison/bison/lib/Attic/stpcpy.c?view=markup Btw, the problem seems to be finished, and that's very good. :)
> This replacing is not wrong. it is wrong for upstream ... but it's a non issue since it's been fixed correctly in upstream cpio cvs
added a revised version of this patch to cvs
