Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 123233 - Cannot build flex-2.5.31 on Gentoo/*BSD
Summary: Cannot build flex-2.5.31 on Gentoo/*BSD
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All Other
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-17 22:55 UTC by Benigno B. Junior (RETIRED)
Modified: 2006-04-12 10:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
flex-2.5.31-scan.c.patch (flex-2.5.31-scan.c.patch,256 bytes, patch)
2006-02-17 22:56 UTC, Benigno B. Junior (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benigno B. Junior (RETIRED) gentoo-dev 2006-02-17 22:55:31 UTC
The patch "flex-2.5.31-isatty.patch" is killing the flex of being compiled on G/NBSD. According to bug #119598, this patch is needed to build doxygen (USE=qt), and I could see this, really. The only problem I've found with this patch is the __THROW used in scan.c (the other in skel.c does not affect here). So I dropped this and it works fine here and on Linux (I tested building doxygen with USE=qt).

Please, people from others BSD's, could confirm this? I'm attaching the patch that worked.
Comment 1 Benigno B. Junior (RETIRED) gentoo-dev 2006-02-17 22:56:25 UTC
Created attachment 80064 [details, diff]
flex-2.5.31-scan.c.patch

There it goes.
Comment 2 Robert Sebastian Gerus 2006-02-18 00:36:18 UTC
Compiled on DragonFly with this patch. Failed without it.
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-02-18 03:37:57 UTC
The problem is that __THROW is an extra specifier that's added by glibc, so BSD systems using non-GNU libcs are breaking.
Just removing it from the patch solves the problem in a quicker way.
I wonder if uclibc still builds flex fine.

Anyway, reassigning to base system, although I'm losing flex++ on my fbsd system with the new version, but probably it's a different problem.
Comment 4 SpanKY gentoo-dev 2006-02-18 11:32:48 UTC
Comment on attachment 80064 [details, diff]
flex-2.5.31-scan.c.patch

no, patch is incorrect
Comment 5 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-02-18 11:42:04 UTC
Which one? The one currently in portage or this one?
Comment 6 Benigno B. Junior (RETIRED) gentoo-dev 2006-02-18 12:55:56 UTC
lol, I didn't put this "patch" to be a real patch for anything. If something is wrong, vapier did it. I was just showing this is not acceptable for us.
Comment 7 SpanKY gentoo-dev 2006-02-18 13:53:52 UTC
i meant the posted patch is wrong

fixed in cvs