Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 122667 - denyhosts-2.1.ebuild (Update)
Summary: denyhosts-2.1.ebuild (Update)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: Benjamin Smee (strerror) (RETIRED)
URL: http://denyhosts.sourceforge.net/
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-13 03:58 UTC by Arthur Magill
Modified: 2006-02-28 03:45 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
denyhosts-2.1.ebuild (denyhosts-2.1.ebuild,1.60 KB, text/plain)
2006-02-13 04:04 UTC, Arthur Magill
Details
denyhosts-gentoo.patch (denyhosts-gentoo.patch,2.33 KB, patch)
2006-02-13 04:13 UTC, Arthur Magill
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arthur Magill 2006-02-13 03:58:05 UTC
Hi,

I've updated the file denyhosts-gentoo.patch to patch against the latest version of denyhosts (2.1). The only changes needed were in the file denyhosts.cfg-dist. I've included the ebuild as well, but the only change was the version number.

Very minor changes, but this is my first submission, so tell me if I'm doing something dumb!

Arthur
Comment 1 Arthur Magill 2006-02-13 04:04:19 UTC
Created attachment 79673 [details]
denyhosts-2.1.ebuild

V. minor change - version number in header updated from 1.1.2-r1 to 2.1
Comment 2 Arthur Magill 2006-02-13 04:13:02 UTC
Created attachment 79675 [details, diff]
denyhosts-gentoo.patch

Updated the patch to fit against v2.1. Changes line numbers to match the new config file.

Also, Denyhost has moved the working dir to

WORK_DIR = /usr/share/denyhosts/data

Gentoo previously used

WORK_DIR = /var/lib/denyhosts

I left /usr/share/denyhosts/data - this seems sensible to me, but I'm not sure of Gentoo policy so please correct if it's wrong.
Comment 3 Mike Kelly 2006-02-19 18:23:35 UTC
Hmm... it seems to me that /var is where variable data (like the stuff that denyhosts uses) should be, but /usr/share is where static data (like pixmaps, help files, etc) should be. So, I'd keep it as it was before, with 'WORK_DIR = /var/lib/denyhosts' (although I may be a little biased, since I wrote the first ebuild :-p ).

Also, if this patch will not apply cleanly to previous versions of denyhosts, it should be given a version number, like denyhosts-gentoo-0.1.patch. The old versions will continue to exist in portage for a while and your updates shouldn't break them.
Comment 4 Arthur Magill 2006-02-20 01:11:04 UTC
On reflection, /var does seem like a better home. I'll update and add a version no. to the patch. Thanks for the comments (and the original ebuild),

Arthur
Comment 5 Benjamin Smee (strerror) (RETIRED) gentoo-dev 2006-02-20 03:23:27 UTC
sorry about the delay on this I've been away for a few weeks and I won't be back till next Monday. I'll be looking to get the new version just as soon as I have a few moments. 

Re the ebuild itself, it is a gentoo standard (one that complies with FHS2) to use /var/lib/APPNAME for application variable data.
Comment 6 Daniel Webert 2006-02-20 13:29:06 UTC
new homepage: www.denyhosts.net
Comment 7 Benjamin Smee (strerror) (RETIRED) gentoo-dev 2006-02-28 03:45:05 UTC
new version in cvs, thanks for reporting