Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 122592 - xvidcap - reenable audio (including patches)
Summary: xvidcap - reenable audio (including patches)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Desktop Misc. Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-12 11:37 UTC by Clemens Fruhwirth
Modified: 2006-02-14 04:10 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch. Drop use-ffmpeg-0.4.9, add configure patch. (xvidcap-1.1.3-r3.diff,483 bytes, patch)
2006-02-12 11:39 UTC, Clemens Fruhwirth
Details | Diff
replacement for new-ffmpeg.patch in xvidcap/files (xvidcap-1.1.3-new-ffmpeg.patch,11.39 KB, patch)
2006-02-12 11:40 UTC, Clemens Fruhwirth
Details | Diff
patch for broken configure.ac. (xvidcap-1.1.3-configure.patch,1.43 KB, patch)
2006-02-12 11:41 UTC, Clemens Fruhwirth
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Clemens Fruhwirth 2006-02-12 11:37:59 UTC
Audio capture support in xvidcap is broken for two reasons:

1. configure is broken. There is are nested checks for audio_init in configure.ac. Usually this does NOT work unless one unsets ac_lib_<libname>_<function>. This was done but obviously there was a change in the check from "audio_open" to "audio_init" .. All was changed. The "unset" hack was forgotten. Welcome to autotools hell. 

2. Various API changes in FFmpeg. I unified the patches use-ffmpeg-0.4.9 and new-ffmpeg and added my own set of changes for the audio section (that was never compiled because HAVE_FFMPEG_AUDIO was never enabled because of the autoconf crap above).

Apply all patches, and drop use-ffmpeg-0.4.9.
Comment 1 Clemens Fruhwirth 2006-02-12 11:39:32 UTC
Created attachment 79588 [details, diff]
ebuild patch. Drop use-ffmpeg-0.4.9, add configure patch.
Comment 2 Clemens Fruhwirth 2006-02-12 11:40:28 UTC
Created attachment 79589 [details, diff]
replacement for new-ffmpeg.patch in xvidcap/files
Comment 3 Clemens Fruhwirth 2006-02-12 11:41:48 UTC
Created attachment 79590 [details, diff]
patch for broken configure.ac.

audio_open is the old name. audio_init is new.
unset neccessary because of autoconf AC_CHECK_LIB_STATIC/AC_CHECK_LIB nesting.
Comment 4 Krzysztof Pawlik (RETIRED) gentoo-dev 2006-02-14 03:21:34 UTC
Commited as -r4 with some changes:
 * the patch can't be named new-ffmpeg.patch as it would break -r3, it's named -ffmpeg.patch
 * patching configure is pointless

Thanks for your work.
Comment 5 Clemens Fruhwirth 2006-02-14 03:57:23 UTC
IIRC, I needed to patch configure too. Not just configure.ac.

However, after a few rounds of testing, it seems that my work was futile, as xvidcap has broken audio/video syncing. I'm not sure if my patch is complete. Maybe somebody wants to look at the audio_pts/video_pts calculation. This was too messy for me. I have reimplemented a screen recorder in ffmpeg which works finally.
Comment 6 Krzysztof Pawlik (RETIRED) gentoo-dev 2006-02-14 04:10:00 UTC
After patching configure.ac and running eautoreconf configure is recreated, so patching it is not needed. Currently it's in ~arch, eventually the audio capture patches can be toggled with USE flag.