Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 122241 - installation of horde should force use flags for php
Summary: installation of horde should force use flags for php
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: SpanKY
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-09 05:03 UTC by Jared Greenwald
Modified: 2006-02-10 21:08 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Greenwald 2006-02-09 05:03:15 UTC
Horde (and the entire horde suite) require the USE flag "session" to be enabled in php for specific functions in php to be enabled.  There should be something like this (from PEAR-PEAR) enabled in horde:

 * Checking for required PHP feature(s):
 *   Discovered missing USE flag xml
 *
 * dev-lang/php-5.0.5-r5 needs to be re-installed with all of the following
 * USE flags enabled:
 *
 *   cli pcre xml zlib
 *

Except that it should require "session" at least.
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2006-02-09 05:31:05 UTC
It sorta does, but yeah, I don't quite understand why horde requires "nls session xml" for php-5 and only "nls" for php-4. 

Anyway, current horde.eclass checks cannot work with dev-lang/php (it checks for mod_php use flags, i.a.). I'd suggest inheriting depend.php eclass and using require_php_with_use ${HORDE_PHP_FEATURES} - but then I don't understand all this -o business in there and how does e.g. USE="nls" make up for the lack of USE="session".

Comment 2 SpanKY gentoo-dev 2006-02-09 21:11:29 UTC
www-apps/horde already searches for 'session' in php

previously horde only looked for 'session' in php-5 because at the time, php-4 didnt support the flag
Comment 3 Jared Greenwald 2006-02-09 22:40:54 UTC
I guess I was advocating using the require_php_with_use similar to what's used for the PEAR-PEAR package, rather than the current HORDE_PHP_FEATURES= method.  This would help since horde doesn't work without php having been built with the session USE flag.
Comment 4 Jakub Moc (RETIRED) gentoo-dev 2006-02-09 23:53:00 UTC
(In reply to comment #3)
> I guess I was advocating using the require_php_with_use similar to what's used
> for the PEAR-PEAR package, rather than the current HORDE_PHP_FEATURES= method. 
> This would help since horde doesn't work without php having been built with the
> session USE flag.

Uhm? With the latest changes in horde ebuild/eclass this look correct, what issues are you still having with that?

<ebuild snip>
HORDE_PHP_FEATURES="nls session xml"
inherit horde
</ebuild snip>

<eclass snip>
if ! built_with_use ${param} dev-lang/php ${HORDE_PHP_FEATURES} ; then
	eerror "You MUST re-emerge php with at least one of"
        eerror "the following options in your USE:"
        eerror " ${HORDE_PHP_FEATURES}"
        die "current php install cannot support ${HORDE_PN}"
fi
</eclass snip>
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2006-02-10 00:07:02 UTC
OK, not entirely, the check is now correct but the advise given is misleading in cased where ${param} != "-o". What about this:

if ! built_with_use ${param} dev-lang/php ${HORDE_PHP_FEATURES} ; then
	if [ "${param}" == "-o" ]; then
		eerror "You MUST re-emerge php with at least one of"
        	eerror "the following options in your USE:"
	        eerror " ${HORDE_PHP_FEATURES}"
        	die "current php install cannot support ${HORDE_PN}"
	else
		eerror "You MUST re-emerge php with at all of"
        	eerror "the following options in your USE:"
	        eerror " ${HORDE_PHP_FEATURES}"
       		die "current php install cannot support ${HORDE_PN}"
	fi
fi
Comment 6 SpanKY gentoo-dev 2006-02-10 21:08:51 UTC
tweaked comment in eclass (but didnt use your broken english :P)