Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 12217 - vkeybd-0.1.12.ebuild (New Package)
Summary: vkeybd-0.1.12.ebuild (New Package)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High enhancement
Assignee: Arcady Genkin (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-12-15 16:58 UTC by Rene Wagner
Modified: 2003-02-04 19:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
vkeybd-0.1.12.ebuild (vkeybd.tar.gz) (vkeybd.tar.gz,1.38 KB, text/plain)
2002-12-15 17:03 UTC, Rene Wagner
Details
vkeybd-0.1.12.ebuild.diff (vkeybd-0.1.12.ebuild.diff,969 bytes, text/plain)
2002-12-22 10:00 UTC, Rene Wagner
Details
vkeybd-0.1.12.ebuild.diff2 (vkeybd-0.1.12.ebuild.diff2,336 bytes, text/plain)
2002-12-23 07:53 UTC, Rene Wagner
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rene Wagner 2002-12-15 16:58:15 UTC
Hi!

Please find attached vkeybd.tar.gz containing vkeybd-0.1.12.ebuild,
files/vkeybd-0.1.12-Makefile.passvariables.patch (a patch that makes it possible
to pass some variables to the Makefile from the ebuild script), and
files/vkeybd-0.1.12-Makefile.destdir.patch (adds $DESTDIR support to the Makefile).

vkeybd is a virtual MIDI keyboard for X.

The Makefile makes me think that vkeybd depends on tcl/tk 8.3.*. Please correct
that if neccessary.

vkeybd is quite useful for testing an initial ALSA/MIDI setup. Yet, it can also
be used in conjunction with other ALSA/MIDI programs.

I suggest media-sound/vkeybd.

Regards,

Rene

PS: I've already submitted pmidi and aseqview, which are other ALSA/MIDI tools
that may be used together with vkeybd; more MIDI programs to follow.
Comment 1 Rene Wagner 2002-12-15 17:03:48 UTC
Created attachment 6529 [details]
vkeybd-0.1.12.ebuild (vkeybd.tar.gz)

$ tar cvfz vkeybd.tar.gz vkeybd 
vkeybd/
vkeybd/files/
vkeybd/files/vkeybd-0.1.12-Makefile.passvariables.patch
vkeybd/files/vkeybd-0.1.12-Makefile.destdir.patch
vkeybd/vkeybd-0.1.12.ebuild
Comment 2 Arcady Genkin (RETIRED) gentoo-dev 2002-12-20 23:18:55 UTC
Okay, committed.  THanks.

Note that the ebuild was a bit garbled ($myconf was manipulated outside of
src_compile()) and you were missing PREFIX assignment in make installs.  I fixed
those.  Please test.
Comment 3 Rene Wagner 2002-12-22 10:00:10 UTC
Created attachment 6665 [details]
vkeybd-0.1.12.ebuild.diff

I assume that global variables are not wanted/allowed in ebuilds.

This patch removes references to the perviously global variable ${myconf} from
src_install() (which had PREFIX=/usr set BTW).

Also it sets the IUSE variable and adds an error message in case make fails.

Regards,

Rene

PS: Sorry, I didn't know how to add this to ChangeLog (I can't set the date and
stuff).
Comment 4 Arcady Genkin (RETIRED) gentoo-dev 2002-12-22 21:42:59 UTC
okay, let me look at this
Comment 5 Rene Wagner 2002-12-23 07:53:25 UTC
Created attachment 6690 [details]
vkeybd-0.1.12.ebuild.diff2

The URL of the source tarball had been changed from .gz to .bz2...
I haven't been able to test whether that URL was valid as www.alsa-project.org
seems to have been down.

However, the URL is invalid.

This one line patch corrects the URL which has to be
http://www.alsa-project.org/~iwai/vkeybd-0.1.12.tar.gz

Regards,

Rene
Comment 6 Arcady Genkin (RETIRED) gentoo-dev 2002-12-25 12:06:38 UTC
Okay, I committed most of the changes that you suggested.  The reason I had
.tar.bz2 instead of .tar.gz was that the package was unavailable from the
website, but I found a .tar.bz2 archive in a SUSE RPM. ;^)

In IUSE you should only put the USE flags that are actually used in the ebuild.
 In this ebuild you only use 'alsa' flag ('oss' is not used, so it should not be
in the IUSE).

Thanks for your persistence.  Please test.
Comment 7 Rene Wagner 2002-12-25 15:30:00 UTC
Well... the ebuild should work now.

But... is it just me, or

$ cat /usr/portage/media-sound/vkeybd/vkeybd-0.1.12.ebuild | grep oss
                use oss || myconf="${myconf} USE_AWE=0 USE_MIDI=0"

doesn't that count as using the oss USE variable?

Merry Christmas,

Rene
Comment 8 Arcady Genkin (RETIRED) gentoo-dev 2002-12-26 10:38:27 UTC
Oops, of course!  Fixed in CVS version 1.3.
Thanks for keeping me straight.