Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 122063 - net-analyzer/base-1.2.2 ebuild fixes
Summary: net-analyzer/base-1.2.2 ebuild fixes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Marcelo Goes (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-07 16:52 UTC by Travis Post
Modified: 2006-02-08 11:13 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
base-1.2.2-r1.ebuild (base-1.2.2-r1.ebuild,6.58 KB, text/plain)
2006-02-07 16:53 UTC, Travis Post
Details
net-analyzer/base-1.2.2-r1 ebuild (base-1.2.2-r1(1).ebuild,5.78 KB, text/plain)
2006-02-08 04:22 UTC, Jakub Moc (RETIRED)
Details
net-analyzer/base-1.2.2-r1 ebuild (base-1.2.2-r1.ebuild,6.72 KB, text/plain)
2006-02-08 06:46 UTC, Jakub Moc (RETIRED)
Details
net-analyzer/base-1.2.2-r1 ebuild (fixed typo) (base-1.2.2-r1.ebuild,6.72 KB, text/plain)
2006-02-08 07:03 UTC, Jakub Moc (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Travis Post 2006-02-07 16:52:23 UTC
Hi,

Please consider attached update to net-analyzer/base. Update includes support for PHP5, Cherokee web server, and proper default configuration for >=dev-php/adodb-4.68 users.

Thanks,

Travis Post
Comment 1 Travis Post 2006-02-07 16:53:19 UTC
Created attachment 79177 [details]
base-1.2.2-r1.ebuild
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2006-02-08 01:53:33 UTC
(In reply to comment #1)

The dependencies are wrong. Besides the weird syntax, your depend on dev-php5/jpgraph will pull in php-5, which may be undesired for a bunch of people. I'll attach a better ebuild if I have time. Also, unified diffs are generally preferred.
Comment 3 Travis Post 2006-02-08 03:37:58 UTC
(In reply to comment #2)
> (In reply to comment #1)
> 
> The dependencies are wrong.
Which ones?

>Besides the weird syntax, your depend on
> dev-php5/jpgraph will pull in php-5, which may be undesired for a bunch of
> people.
That's true, but depending on dev-php4/jpgraph will pull in php-4, which may be just as undesirable. There's no elegant solution, unless a new USE flag is implemented.

As it currently stands, somebody is going to be without graphing support--either PHP4 users or PHP5 users. I just decided PHP4 users would do without since PHP5 has been marked stable. And PHP4 can actually still create charts, it just takes more effort on their part.

This ebuild won't pull in PHP5 so long as the user disables the "gd" and "gd-external" use flags for this package. And PHP4 users should disable gd and gd-external in BASE since they're only needed for graphing. By disabling gd, PHP4 users will have fewer dependencies than those who want to create charts. It also provides flexibility for those PHP5 users who don't want graphing support. They can also disable gd, and do without all the unnecessary dependencies (including jpgraph).

Anyway, I'm sure the ebuild isn't perfect, but it should be very flexible and easy to maintain. I'd appreciate any help you can offer in writing a new one.
Comment 4 Jakub Moc (RETIRED) gentoo-dev 2006-02-08 04:22:35 UTC
Created attachment 79218 [details]
net-analyzer/base-1.2.2-r1 ebuild

- fixed gd deps
- dropped gd-external use flag completely; require_gd will check for required gd gd support in php (either gd or gd-external) and avoid bloat in the ebuild
- dropped conditional check and sed on adodb <4.68 (depend.php assumes >=adodb-4.68 so that was completely pointless)
- dropped cherokee entirely, not familiar with that and webapps are supposed to work with any webserver, cherokee is a weird alternative webserver anyway. If you insist on doing some additional configuration for users' convenience, use lighttpd instead.
- moved mysql/postgresql to RDEPEND
- dropped bogus apache/apache2 from IUSE (want_apache takes care of this)
- changed need_apache to want_apache and dropped a couple of related redundant stuff
- dropped bogus session use flag
- added back a couple of "${S}" quotes that you've dropped for no reason
- dropped oci8 use flag, why did you add it? We don't need two use flags for the same thing.
- hmmm, did I forget something?

Also, the ebuild in portage doesn't check for conflicting use flags at all and does sed-ing in src_unpack() according to them, needs to be fixed somehow, else you end up with $DBType = "oracle" if you set USE="mysql oracle" e.g. Easiest solution would be to drop this part (and related use flags) entirely and let user do the job.
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2006-02-08 04:45:05 UTC
One more note - for stuff like mysql, postgres, mssql or oracle - you need relevant support in php as well for this stuff to work with net-analyzer/base, (whether those DBs are local or not), right? Another thing that this ebuild doesn't check for at all...
Comment 6 Jakub Moc (RETIRED) gentoo-dev 2006-02-08 06:46:36 UTC
Created attachment 79227 [details]
net-analyzer/base-1.2.2-r1 ebuild

Additional fixes for the above-mentioned issues. Please test, won't have more time to spend on this.
Comment 7 Jakub Moc (RETIRED) gentoo-dev 2006-02-08 07:03:12 UTC
Created attachment 79231 [details]
net-analyzer/base-1.2.2-r1 ebuild (fixed typo)

Sigh, left a stupid mistake in there... Fixed now.
Comment 8 Marcelo Goes (RETIRED) gentoo-dev 2006-02-08 11:13:14 UTC
Thanks, in cvs.