Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 121862 - dev-libs/popt-1.10.4 keywording request
Summary: dev-libs/popt-1.10.4 keywording request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: MIPS Porters
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-06 12:27 UTC by Sandro Bonazzola (RETIRED)
Modified: 2007-01-12 21:53 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
new ebuild (popt-1.10.4.ebuild,785 bytes, text/plain)
2006-02-22 11:55 UTC, Sandro Bonazzola (RETIRED)
Details
autotool stuff removed, test failure still present (popt-1.10.4.ebuild,708 bytes, text/plain)
2006-02-23 11:15 UTC, Sandro Bonazzola (RETIRED)
Details
Simple program that shows the problem causing test stage to fail (test_dash.c,947 bytes, text/plain)
2006-09-14 17:00 UTC, Wormo (RETIRED)
Details
add a printf to section that shouldn't be executed... but IS. (popt-1.10.4-cant-happen.diff,399 bytes, patch)
2006-09-16 09:16 UTC, Wormo (RETIRED)
Details | Diff
popt-1.10.7.ebuild (popt-1.10.7.ebuild,965 bytes, text/plain)
2006-11-03 15:38 UTC, Timothy Redaelli (RETIRED)
Details
files/popt-1.10.4-test.patch (popt-1.10.4-test.patch,504 bytes, patch)
2006-11-03 15:41 UTC, Timothy Redaelli (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sandro Bonazzola (RETIRED) gentoo-dev 2006-02-06 12:27:10 UTC
is this unmaintained? metadata.xml is not present.
ebuilds update needed.
Comment 1 Marcelo Goes (RETIRED) gentoo-dev 2006-02-18 19:23:45 UTC
Sandro: If I were you I would go ahead and bump it.
Comment 2 SpanKY gentoo-dev 2006-02-18 22:06:42 UTC
whoever feels like taking on the rpm package should also take on the popt package
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-02-19 05:50:06 UTC
As long as the API remained the same just go on.
Comment 4 Sandro Bonazzola (RETIRED) gentoo-dev 2006-02-20 11:59:29 UTC
Ok, according to www.rpm.org, 'The long time RPM maintainer, Jeff Johnson, keeps an archive at: ftp://jbj.org/pub/rpm-* and "has the latest bits he has touched".'

I'm downloading ftp://jbj.org/pub/rpm-4.4.x/popt-1.10.4.tar.gz but I'm not sure if the rpm.org community has a different version. I'm gonna try this on my system against all the application I've on it that uses popt. If anybody know a better "canonical" place for popt, please let me know it.
Comment 5 Sandro Bonazzola (RETIRED) gentoo-dev 2006-02-22 11:29:37 UTC
I need help figuring out why test phase fails. The api seems unchanged seeinf differences in the source tree (with meld). I'm testing it under ~x86 and seems nothing broken untill now (two days normal running after revdep-rebuild -soname  /usr/lib/libpopt.so.0 . Actually I've restricted test... for testing purpose :-/

--- popt-1.7-r1.ebuild  2006-02-21 20:22:01.000000000 +0100
+++ popt-1.10.4.ebuild  2006-02-22 20:22:44.000000000 +0100
@@ -1,28 +1,28 @@
 # Copyright 1999-2006 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/dev-libs/popt/popt-1.7-r1.ebuild,v 1.22 2006/01/25 21:07:05 flameeyes Exp $
+# $Header: $

 inherit libtool eutils flag-o-matic autotools

 DESCRIPTION="Parse Options - Command line parser"
 HOMEPAGE="http://www.rpm.org/"
-SRC_URI="ftp://ftp.rpm.org/pub/rpm/dist/rpm-4.1.x/${P}.tar.gz"
+SRC_URI="ftp://jbj.org/pub/rpm-4.4.x/${P}.tar.gz"

 LICENSE="as-is"
 SLOT="0"
-KEYWORDS="alpha amd64 arm hppa ia64 m68k mips ppc ppc64 ppc-macos s390 sh sparc x86"
+KEYWORDS="~x86"
 IUSE="nls"

 RDEPEND="nls? ( virtual/libintl )"
 DEPEND="nls? ( sys-devel/gettext )"

+#test fail. I can't figure out why.
+RESTRICT=test
+
 src_unpack() {
        unpack ${A}
        cd "${S}"
-       epatch "${FILESDIR}"/${P}-missing-tests.patch
-       epatch "${FILESDIR}"/${P}-nls.patch
-       use nls || touch ../rpm.c
-
+       #use nls || touch ../rpm.c
        eautomake
        elibtoolize
 }
Comment 6 Sandro Bonazzola (RETIRED) gentoo-dev 2006-02-22 11:55:16 UTC
Created attachment 80446 [details]
new ebuild

The ebuild for faster testing :-)
Comment 7 SpanKY gentoo-dev 2006-02-22 15:03:26 UTC
any reason you're running autotool stuff still ?
Comment 8 Sandro Bonazzola (RETIRED) gentoo-dev 2006-02-23 11:15:10 UTC
Created attachment 80538 [details]
autotool stuff removed, test failure still present

(In reply to comment #7)
> any reason you're running autotool stuff still ?

forgot to remove them. The make process rerun autoheader by itself.
Comment 9 Mike Doty (RETIRED) gentoo-dev 2006-03-13 11:13:04 UTC
amd64 ATs, please test
Comment 10 Sandro Bonazzola (RETIRED) gentoo-dev 2006-09-07 11:08:38 UTC
No report from ATs...
Comment 11 Christoph Mende (RETIRED) gentoo-dev 2006-09-08 05:21:50 UTC
emerges fine on amd64, passes test-suite (yea, really!), multilib-strict and collision-test, works

Portage 2.1-r2 (default-linux/amd64/2006.1/desktop, gcc-4.1.1, glibc-2.4-r3, 2.6.17-ck1-r3 x86_64)
=================================================================
System uname: 2.6.17-ck1-r3 x86_64 AMD Athlon(tm) 64 Processor 3000+
Gentoo Base System version 1.12.4
ccache version 2.3 [enabled]
app-admin/eselect-compiler: [Not Present]
dev-lang/python:     2.4.3-r1
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     2.3
dev-util/confcache:  [Not Present]
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.59-r7
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2
sys-devel/binutils:  2.16.1-r3
sys-devel/gcc-config: 1.3.13-r3
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.11-r2
ACCEPT_KEYWORDS="amd64"
AUTOCLEAN="yes"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=k8 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/X11/xkb"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf /etc/java-config/vms/ /etc/revdep-rebuild /etc/terminfo"
CXXFLAGS="-march=k8 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig ccache collision-test distlocks metadata-transfer multilib-strict parallel-fetch sandbox sfperms strict test"
GENTOO_MIRRORS="ftp://sunsite.informatik.rwth-aachen.de/pub/Linux/gentoo ftp://linux.rz.ruhr-uni-bochum.de/gentoo-mirror/ ftp://ftp.uni-erlangen.de/pub/mirrors/gentoo ftp://ftp.join.uni-muenster.de/pub/linux/distributions/gentoo ftp://ftp.wh2.tu-dresden.de/pub/mirrors/gentoo ftp://ftp.join.uni-muenster.de/pub/linux/distributions/gentoo ftp://ftp-stud.fht-esslingen.de/pub/Mirrors/gentoo/ ftp://ftp.gentoo.mesh-solutions.com/gentoo/ ftp://pandemonium.tiscali.de/pub/gentoo/ "
LANG="en_US.ISO8859-1"
LC_ALL="en_US.ISO8859-1"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_EXTRA_OPTS="--exclude-from=/etc/portage/rsync_excludes"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude='/distfiles' --exclude='/local' --exclude='/packages'"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage/overlay"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="amd64 X a52 aac acpi alsa amr asf avi berkdb bitmap-fonts bzip2 cairo cdinstall cdparanoia cdr cli crypt cups dbus divx dlloader dri dvd dvdr dvdread emboss encode expat fam firefox fortran gdbm gif glut gpm gstreamer gtk gtk2 hal imagemagick isdnlog jpeg lcms ldap libg++ lirc mad mikmod mng mp3 mpeg musicbrainz ncurses nls nptl nptlonly ogg opengl pam pcre pdflib php png ppds pppd quicktime readline reflection sdl session socks5 spl ssl svg tcpd tiff truetype truetype-fonts type1-fonts udev unicode v4l v4l2 vorbis wmp x264 xine xinerama xml xorg xv xvid zlib elibc_glibc input_devices_evdev input_devices_keyboard kernel_linux lirc_devices_inputlirc userland_GNU video_cards_fglrx"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LDFLAGS, LINGUAS
Comment 12 Sandro Bonazzola (RETIRED) gentoo-dev 2006-09-09 10:46:13 UTC
(In reply to comment #11)
> emerges fine on amd64, passes test-suite (yea, really!), multilib-strict and
> collision-test, works

All right. I'm going to commit it, assigning myself as maintainer. I'll keyword it ~amd64. x86 arch testers, please keyword it ~x86 if anybody can confirm it doesn't break anything under x86.
Comment 13 Patrick McLean gentoo-dev 2006-09-09 13:42:58 UTC
The 1.10.4 ebuild is broken on amd64, please see bug #146988.
Comment 14 Sandro Bonazzola (RETIRED) gentoo-dev 2006-09-10 14:02:37 UTC
Well, a new bump was required due to bug #146988, #147044, #147066.
Please test the new ebuild (already in portage, package masked) and keyword it accordingly to test result. Please during the test don't try only to build it, try also to rebuild everything that links against the old version.
Comment 15 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-09-10 14:53:38 UTC
~x86-fbsd keyword re-added.
Comment 16 Christoph Mende (RETIRED) gentoo-dev 2006-09-10 14:57:13 UTC
well, last version I tried worked too (tried nautilus and eog), but anyways..

- 1.10.4-r1 emerges fine on amd64
- passes multilib-strict
- passes collision-test
- works (again, tried with nautilus and eog)

Portage 2.1.1 (default-linux/amd64/2006.1/desktop, gcc-4.1.1, glibc-2.4-r3, 2.6.17-ck1-r3 x86_64)
=================================================================
System uname: 2.6.17-ck1-r3 x86_64 AMD Athlon(tm) 64 Processor 3000+
Gentoo Base System version 1.12.4
Last Sync: Sun, 10 Sep 2006 21:20:01 +0000
ccache version 2.3 [enabled]
app-admin/eselect-compiler: [Not Present]
dev-lang/python:     2.4.3-r1
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     2.3
dev-util/confcache:  [Not Present]
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.59-r7
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2
sys-devel/binutils:  2.16.1-r3
sys-devel/gcc-config: 1.3.13-r3
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.11-r2
ACCEPT_KEYWORDS="amd64"
AUTOCLEAN="yes"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=k8 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/X11/xkb"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf /etc/java-config/vms/ /etc/revdep-rebuild /etc/terminfo"
CXXFLAGS="-march=k8 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig ccache collision-test distlocks metadata-transfer multilib-strict parallel-fetch sandbox sfperms strict test"
GENTOO_MIRRORS="ftp://sunsite.informatik.rwth-aachen.de/pub/Linux/gentoo ftp://linux.rz.ruhr-uni-bochum.de/gentoo-mirror/ ftp://ftp.uni-erlangen.de/pub/mirrors/gentoo ftp://ftp.join.uni-muenster.de/pub/linux/distributions/gentoo ftp://ftp.wh2.tu-dresden.de/pub/mirrors/gentoo ftp://ftp.join.uni-muenster.de/pub/linux/distributions/gentoo ftp://ftp-stud.fht-esslingen.de/pub/Mirrors/gentoo/ ftp://ftp.gentoo.mesh-solutions.com/gentoo/ ftp://pandemonium.tiscali.de/pub/gentoo/ "
LANG="en_US.ISO8859-1"
LC_ALL="en_US.ISO8859-1"
LINGUAS=""
MAKEOPTS="-j1"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_EXTRA_OPTS="--exclude-from=/etc/portage/rsync_excludes"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude='/distfiles' --exclude='/local' --exclude='/packages'"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage/overlay"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="amd64 X a52 aac acpi alsa amr avi berkdb bitmap-fonts branding bzip2 cairo cdinstall cdparanoia cdr cli crypt cups dbus divx dlloader dri dvd dvdr dvdread elibc_glibc emboss encode expat fam firefox fortran gdbm gif glut gpm gstreamer gtk gtk2 hal imagemagick input_devices_evdev input_devices_keyboard isdnlog jpeg kernel_linux lcms ldap libg++ lirc lirc_devices_inputlirc mad mikmod mng mp3 mpeg musicbrainz ncurses nls nptl nptlonly ogg opengl pam pcre pdflib php png ppds pppd quicktime readline reflection sdl session socks5 spl ssl svg tcpd tiff truetype truetype-fonts type1-fonts udev unicode userland_GNU v4l v4l2 video_cards_fglrx vorbis wmp x264 xine xinerama xml xorg xv xvid zlib"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LDFLAGS
Comment 17 Fabian Groffen gentoo-dev 2006-09-11 12:24:15 UTC
No go on ppc-macos.  Probably autotools version mismatch.


***** automake *****

Makefile.am:42: libpopt_la_LDFLAGS was already defined in condition TRUE, which implies condition HAVE_LD_VERSION_SCRIPT_TRUE

  libpopt_la_LDFLAGS (User, where = Makefile.am:42) +=
  {
    TRUE => -no-undefined @INTLLIBS@
  }

Comment 18 Joshua Jackson (RETIRED) gentoo-dev 2006-09-11 20:31:56 UTC
added ~x86 seems to work fine here.
Comment 19 Markus Rothe (RETIRED) gentoo-dev 2006-09-12 01:04:45 UTC
added ~ppc64
Comment 20 Aron Griffis (RETIRED) gentoo-dev 2006-09-13 10:40:39 UTC
ia64 done
Comment 21 Sandro Bonazzola (RETIRED) gentoo-dev 2006-09-13 11:19:36 UTC
(In reply to comment #17)
> No go on ppc-macos.  Probably autotools version mismatch.

Ok, I'll take a look at it but I lack the hardware for testing. I'm going to unmask the ebuild. Remaining archs, please keyword it accordingly to test results. I leave the bug open since keywording finished and ppc-macos fixed.
Comment 22 Wormo (RETIRED) gentoo-dev 2006-09-14 14:13:17 UTC
The test failure looks like a real regression in the library. The test1 program set up '-' (a single dash) as one of the options. popt 1.7 successfully parsed '-' as an option, but popt 1.10 does not...

Comment 23 Wormo (RETIRED) gentoo-dev 2006-09-14 17:00:12 UTC
Created attachment 97015 [details]
Simple program that shows the problem causing test stage to fail
Comment 24 Wormo (RETIRED) gentoo-dev 2006-09-14 17:03:17 UTC
Comment on attachment 97015 [details]
Simple program that shows the problem causing test stage to fail

based on test1.c in popt toplevel dir
Comment 25 Sandro Bonazzola (RETIRED) gentoo-dev 2006-09-15 11:14:53 UTC
(In reply to comment #22)
> The test failure looks like a real regression in the library. The test1 program
> set up '-' (a single dash) as one of the options. popt 1.7 successfully parsed
> '-' as an option, but popt 1.10 does not...
> 

I don't know if it's a regression or if it's a feature.
The 1.7 original code in popt.c says:

if (con->restLeftover || *origOptString != '-') {
...
}

1.10.4 says:

if (con->restLeftover || *origOptString != '-' ||
  (*origOptString == '-' && origOptString[1] == '\0')) {
... 
}

so if - is an option, it has to be terminated.
it can't be a character, it has to be a string terminated by \0.

Comment 26 Wormo (RETIRED) gentoo-dev 2006-09-16 09:13:03 UTC
After more investigation, it still looks like a bug -- single dash now makes it hit one of the conditions marked at "Can't happen" which is what prevents the line that sets "singleDash = 1" from being reached.
Comment 27 Wormo (RETIRED) gentoo-dev 2006-09-16 09:16:21 UTC
Created attachment 97156 [details, diff]
add a printf to section that shouldn't be executed... but IS.

Run test1 app with '-' after this patch has been applied
Comment 28 Guy Martin (RETIRED) gentoo-dev 2006-10-01 08:39:38 UTC
Added ~hppa to keywords.
Comment 29 Fabian Groffen gentoo-dev 2006-10-24 12:17:01 UTC
whatever is the outcome here, ppc-macos keyword is dropped in favour of the prefix.
Comment 30 Jason Wever (RETIRED) gentoo-dev 2006-11-03 14:52:32 UTC
~sparc keyword added.
Comment 31 Timothy Redaelli (RETIRED) gentoo-dev 2006-11-03 15:38:56 UTC
Created attachment 101173 [details]
popt-1.10.7.ebuild
Comment 32 Timothy Redaelli (RETIRED) gentoo-dev 2006-11-03 15:41:18 UTC
Created attachment 101174 [details, diff]
files/popt-1.10.4-test.patch

Now test should works
Comment 33 Christoph Mende (RETIRED) gentoo-dev 2006-11-05 08:06:05 UTC
amd64 already keyworded -r1 and -r2, any special reason we're still here?
Comment 34 Michael Weyershäuser 2006-11-05 08:21:36 UTC
"Nobody removed us" seems to be the only reason ;)
Comment 35 Bryan Østergaard (RETIRED) gentoo-dev 2006-11-05 10:13:10 UTC
Added ~alpha keyword.
Comment 36 Sandro Bonazzola (RETIRED) gentoo-dev 2006-11-07 14:19:01 UTC
(In reply to comment #32)
> Created an attachment (id=101174) [edit]
> files/popt-1.10.4-test.patch
> 
> Now test should works
> 

Patch in cvs, version bump needed as this fixes the regression of comment #22.
Keeping ~keywords.
Changing the summary in keywording, no more things to fix for this version bump.
Comment 37 Timothy Redaelli (RETIRED) gentoo-dev 2006-11-08 09:12:51 UTC
ppc done
Comment 38 Sandro Bonazzola (RETIRED) gentoo-dev 2006-11-13 11:49:14 UTC
sh s390 and arm are done, only mips remains for having this bug fixed.
Comment 39 Sandro Bonazzola (RETIRED) gentoo-dev 2006-12-06 11:55:53 UTC
1.10.7 in portage, version bump thanks to Timothy Redaelli.
Comment 40 Jakub Moc (RETIRED) gentoo-dev 2007-01-12 21:53:59 UTC
Obsoleted by Bug 161177, closing.