Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 121181 - getfilevar from linux-info.eclass does not work correctly on current development kernels
Summary: getfilevar from linux-info.eclass does not work correctly on current developm...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High normal
Assignee: John Mylchreest (RETIRED)
URL:
Whiteboard:
Keywords:
: 119870 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-02-01 07:25 UTC by Andreas Deresch
Modified: 2006-03-03 14:11 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fixes linux-info.eclass to correctly extract variables from recent kernel's makefiles. (linux-info.eclass.diff,433 bytes, patch)
2006-02-01 07:27 UTC, Andreas Deresch
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Deresch 2006-02-01 07:25:59 UTC
getfilevar from linux-info.eclass executes make with a command line target after inclusion of the kernel makefile. This leads to this rule depending on cdbuilddir (from the kernel makefile), which rule executes a separate make on the kernel makefile. This make does not have a definition of the original target and fails. 

This can be amended by defining our target before including the kernel makefile, and executing it as the default target. This approach should also work on previous kernels.

On a sidenote, maybe the target should get a more complex name to avoid possible addition of dependencies by the included Makefile.
Comment 1 Andreas Deresch 2006-02-01 07:27:26 UTC
Created attachment 78655 [details, diff]
Fixes linux-info.eclass to correctly extract variables from recent kernel's makefiles.
Comment 2 John Mylchreest (RETIRED) gentoo-dev 2006-02-08 09:36:55 UTC
Sorry, by the kbuild-output, I meant where abouts does it get set?
Comment 3 John Mylchreest (RETIRED) gentoo-dev 2006-02-08 09:37:13 UTC
ignore that :)
Comment 4 John Mylchreest (RETIRED) gentoo-dev 2006-02-08 11:47:15 UTC
*** Bug 119870 has been marked as a duplicate of this bug. ***
Comment 5 John Mylchreest (RETIRED) gentoo-dev 2006-02-08 11:50:16 UTC
this has been applied locally - will test and commit shortly.
Nice catch, and thanks.
Comment 6 John Mylchreest (RETIRED) gentoo-dev 2006-03-03 14:11:36 UTC
in CVS now. THanks.