Bug 120406 – Add `emacs' use flag to dev-util/bzr-0.6.2 ebuild

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Christian Schlotter 2006-01-26 04:28:13 UTC]

Please find attached the modified ebuild plus needed files.

[Comment 1 Christian Schlotter 2006-01-26 04:28:57 UTC]

Created attachment 78149 [details]
bzr-0.6.2.ebuild

[Comment 2 Christian Schlotter 2006-01-26 04:29:35 UTC]

Created attachment 78150 [details]
files/70bzr-gentoo.el

[Comment 3 Christian Schlotter 2006-01-26 04:30:07 UTC]

Created attachment 78151 [details, diff]
diff to previous ebuild

[Comment 4 Christian Schlotter 2006-01-26 04:40:40 UTC]

Created attachment 78152 [details]
files/70bzr-gentoo.el

Removed unnecessary line.

[Comment 5 Marien Zwart (RETIRED) 2006-01-26 16:52:55 UTC]

Why are you using "(load "bzr-mode.el" nil t t)"? If I read the documentation right the final "t" will make it ignore bzr-mode.elc which seems a waste after creating and installing it :) and I do not see a good reason for hiding the load message either. How about simply (load "bzr-mode")?

[Comment 6 Christian Schlotter 2006-01-27 01:52:44 UTC]

Created attachment 78274 [details]
bzr-0.6.2.ebuild

Spotted a typo.

[Comment 7 Christian Schlotter 2006-01-27 01:54:34 UTC]

Created attachment 78276 [details]
files/70bzr-gentoo.el

(In reply to comment #5)
> Why are you using "(load "bzr-mode.el" nil t t)"? If I read the documentation
> right the final "t" will make it ignore bzr-mode.elc which seems a waste after
> creating and installing it :) and I do not see a good reason for hiding the
> load message either. How about simply (load "bzr-mode")?

Marien, you are right.  Next time I will look at the documentation instead of just copying a line without checking it.

Thanks!

[Comment 8 Marien Zwart (RETIRED) 2006-01-27 05:29:02 UTC]

Added this as part of other changes in bug 120487. Thanks for reporting!