Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 120403 - coreutils-5.93 & autofs
Summary: coreutils-5.93 & autofs
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High critical (vote)
Assignee: Network Filesystems
URL:
Whiteboard:
Keywords: QAcanfix
: 129642 129644 129780 130411 131859 134741 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-01-26 04:09 UTC by Andrej Filipcic
Modified: 2006-05-30 09:45 UTC (History)
15 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
autofs patch (autofs-4.1.4-fix-sort-opts.patch,463 bytes, patch)
2006-01-29 01:33 UTC, Andrej Filipcic
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrej Filipcic 2006-01-26 04:09:40 UTC
sort +POS1 does not work anymore with cureutils-5.93. POSIX or bug?
Anyway, /etc/autofs/auto.net from autofs needs a patch:

--- auto.net.org        2005-11-08 19:49:54.000000000 +0100
+++ auto.net    2006-01-26 13:08:25.824136932 +0100
@@ -22,7 +22,7 @@
 # Newer distributions get this right
 SHOWMOUNT="/usr/sbin/showmount --no-headers -e $key"

-$SHOWMOUNT | LC_ALL=C sort +0 | \
+$SHOWMOUNT | LC_ALL=C sort | \
        awk -v key="$key" -v opts="$opts" -- '
        BEGIN           { ORS=""; first=1 }
                        { if (first) { print opts; first=0 }; print " \\\n\t" $1, key ":" $1 }
Comment 1 SpanKY gentoo-dev 2006-01-26 10:41:22 UTC
most likely it's POSIX rearing it's "helpful" head
Comment 2 Andrej Filipcic 2006-01-29 01:33:28 UTC
Created attachment 78396 [details, diff]
autofs patch

this patch is in fedora devel to fix sort in autofs
Comment 3 Manuel McLure 2006-04-11 18:39:06 UTC
*** Bug 129642 has been marked as a duplicate of this bug. ***
Comment 4 Jakub Moc (RETIRED) gentoo-dev 2006-04-12 00:47:07 UTC
*** Bug 129644 has been marked as a duplicate of this bug. ***
Comment 5 Fabian Groffen gentoo-dev 2006-04-12 01:11:59 UTC
coreutils 5.93 has been stabled without this patch to autofs.  Most likely more systems running "stable" will be broken now.  Please patch/bump autofs stable to fix this.
Comment 6 Andy Wang 2006-04-12 12:58:41 UTC
the fedora patch (-k 1) is more appropriate than dropping the +0 argument entirely (as in the original reporter's comment) as it results in the identical behavior as +0 did.  Not that it REALLY matters what order the mount points are processed in though :)
Comment 7 Jakub Moc (RETIRED) gentoo-dev 2006-04-13 02:12:10 UTC
*** Bug 129780 has been marked as a duplicate of this bug. ***
Comment 8 Jakub Moc (RETIRED) gentoo-dev 2006-04-18 17:38:49 UTC
*** Bug 130411 has been marked as a duplicate of this bug. ***
Comment 9 Jakub Moc (RETIRED) gentoo-dev 2006-05-01 00:31:33 UTC
*** Bug 131859 has been marked as a duplicate of this bug. ***
Comment 10 Tuan Van (RETIRED) gentoo-dev 2006-05-12 10:14:39 UTC
(In reply to comment #5)
> coreutils 5.93 has been stabled without this patch to autofs.  Most likely more
> systems running "stable" will be broken now.  Please patch/bump autofs stable
> to fix this.
> 

This bug isn't moving. QA, please do something about this.
Comment 11 Mark Loeser (RETIRED) gentoo-dev 2006-05-19 18:28:29 UTC
rphillips, robbat2: can one of you please add this patch and bump the latest stable version?  If there is no response in a week, I'll assume it is alright to add this, and I will bump it and add it.
Comment 12 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2006-05-19 19:14:39 UTC
halcy0n: you can go ahead and commit it.
I'm trying to work on the newer autofs stuff - which needs some major rewriting of the init script again :-(.
Comment 13 Mark Loeser (RETIRED) gentoo-dev 2006-05-19 20:43:37 UTC
Fixed.  Thanks Robin.
Comment 14 Fabian Groffen gentoo-dev 2006-05-23 00:55:05 UTC
Bug is NOT fixed.  The added patch only "fixes" the auto.net file that is installed in the samples.  The real problem is the auto.net file that is installed from ${FILESDIR} into /etc/autofs/.  This file still contains the sort +0.

Please change auto.net in ${FILESDIR}, or use the one from the sources and rebump to really fix this annoying issue that still breaks stable systems.
Comment 15 Alec Warner (RETIRED) archtester gentoo-dev Security 2006-05-27 21:52:53 UTC
Refixed
Comment 16 Jakub Moc (RETIRED) gentoo-dev 2006-05-29 03:03:13 UTC
*** Bug 134741 has been marked as a duplicate of this bug. ***
Comment 17 Fabian Groffen gentoo-dev 2006-05-30 01:52:11 UTC
this is really embarassing, but sorry... this fix again breaks a stable system:

% sort +k 1
sort: open failed: +k: No such file or directory

Not sure, but I think it should be "-k 1" which works fine.  Since I am no member of any of the involved groups here, I don't like to commit a fix that works... but please, could someone fix this for real very quickly now?  If you need a patch reviewal on a system (or three) that uses autofs, please send me mail, as I think it is clear that none of the committers actually could try the script out before committing.
Comment 18 Massimiliano Adamo 2006-05-30 02:04:46 UTC
(In reply to comment #17)
> this is really embarassing, but sorry... this fix again breaks a stable system:
> 
> % sort +k 1
> sort: open failed: +k: No such file or directory
> 
> Not sure, but I think it should be "-k 1" which works fine. 


well, we had to wait only few months before seeing the patch available, but not yet in the tree, with the huge change: sort -k 1

?????
Comment 19 Alec Warner (RETIRED) archtester gentoo-dev Security 2006-05-30 08:02:05 UTC
(In reply to comment #17)
> this is really embarassing, but sorry... this fix again breaks a stable system:
> 
> % sort +k 1
> sort: open failed: +k: No such file or directory
> 
> Not sure, but I think it should be "-k 1" which works fine.  Since I am no
> member of any of the involved groups here, I don't like to commit a fix that
> works... but please, could someone fix this for real very quickly now?  If you
> need a patch reviewal on a system (or three) that uses autofs, please send me
> mail, as I think it is clear that none of the committers actually could try the
> script out before committing.
> 

No this was completely my fault, I even looked at the sort manpage before changing it! :/
Comment 20 Jakub Moc (RETIRED) gentoo-dev 2006-05-30 09:45:27 UTC
*** Bug 134929 has been marked as a duplicate of this bug. ***