Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 12023 - netkit-base-0.17-r7.ebuild (Update)
Summary: netkit-base-0.17-r7.ebuild (Update)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: Nick Hadaway
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-12-12 09:50 UTC by Ragnar Hojland Espinosa
Modified: 2003-01-02 10:20 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
netkit-base-0.17-r7.ebuild (Update) (netkit-base-0.17-r7.ebuild,1.58 KB, application/octet-stream)
2002-12-12 09:52 UTC, Ragnar Hojland Espinosa
Details
cosmetic fix and payload comparision fix (netkit-base-0.17-wrong-byte-fix.patch,641 bytes, patch)
2002-12-12 09:55 UTC, Ragnar Hojland Espinosa
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ragnar Hojland Espinosa 2002-12-12 09:50:50 UTC
bugfixes; passed along to the netkit maintainer, but meanwhile heres a diff.

* cosmetic (looked like a short instead as like a byte):
unpatched prints 
       wrong data byte #0 should be 0xc1 but was 0xbfbf 8a f8 3d 5 4e d 0

better to make it:

       wrong data byte #0 should be 0x96 but was 0x94 94 a7 f8 3d df ad e 0

* real
the origin of above message is this seq:

   send 16
   recv 16

   send 17
   (1 idle sec)

   send 18
   recv 17 (ping goes nuts)

   send 19
   recv 18

   send 1a
   recv 19

given the name of the function, it should merely compare payload data and not
timevals, or maintain a list of pending id+timeval tuples.
Comment 1 Ragnar Hojland Espinosa 2002-12-12 09:52:21 UTC
Created attachment 6435 [details]
netkit-base-0.17-r7.ebuild (Update)
Comment 2 Ragnar Hojland Espinosa 2002-12-12 09:55:43 UTC
Created attachment 6436 [details, diff]
cosmetic fix and payload comparision fix

should not compare timeval, UDP does not warrant in-order packets
Comment 3 Nick Hadaway 2002-12-21 19:55:14 UTC
I will review this.  Please let me know if you get any response from the 
netkit people... 
Comment 4 Ragnar Hojland Espinosa 2002-12-22 15:16:59 UTC
Will do.  I'm not expecting anything, tho.
Comment 5 Nick Hadaway 2002-12-22 16:04:21 UTC
I was contemplating making a comment about how getting a response from the 
netkit (team?) would probably be highly unlikely... I see that your sentiments 
are the same.
Comment 6 Nick Hadaway 2002-12-22 16:21:13 UTC
I have added your ebuild to portage.  It is currently marked unstable.
Comment 7 Nick Hadaway 2003-01-02 10:20:14 UTC
I have updated the ebuild to use epatch.  It is still marked unstable.  Please 
mark this bug VERIFIED if you have no further problems and REOPEN if changes 
need to be made.