Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 120135 - Stop of adsl network interface fails
Summary: Stop of adsl network interface fails
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] baselayout (show other bugs)
Hardware: All Linux
: High normal
Assignee: Roy Marples (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-23 21:40 UTC by Matt Harden
Modified: 2006-01-25 09:18 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to add a semicolon to fix syntax error (adsl.patch,570 bytes, patch)
2006-01-23 21:44 UTC, Matt Harden
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Harden 2006-01-23 21:40:40 UTC
Portage 2.0.54 (default-linux/x86/2005.0, gcc-3.3.6, glibc-2.3.5-r2, 2.6.14-gentoo-r5 i686)
=================================================================
System uname: 2.6.14-gentoo-r5 i686 AMD Athlon(tm)
Gentoo Base System version 1.6.14
distcc 2.18.3 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
ccache version 2.3 [disabled]
dev-lang/python:     2.3.5-r2, 2.4.2
sys-apps/sandbox:    1.2.12
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1
sys-devel/binutils:  2.16.1
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.11-r2
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=athlon-xp -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.3/env /usr/kde/3.3/share/config /usr/kde/3.3/shutdown /usr/kde/3.4/env /usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config /usr/lib/X11/xkb /usr/share/config /usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/ /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -march=athlon-xp -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig distlocks sandbox sfperms strict"
GENTOO_MIRRORS="http://distfiles.gentoo.org http://distro.ibiblio.org/pub/linux/distributions/gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.namerica.gentoo.org/gentoo-portage"
USE="x86 3dnow 3dnowex 3dnowext X X509 acpi adns alsa apache2 apm arts audiofile avi berkdb bluetooth bzip2 bzlib cdb cdda cdparanoia cdr crypt cups curl curlwrappers dba dbase dbm dbx dga directfb dvd dvdr dvdread ecc eds emboss encode esd evo evo2 exif expat fam fastcgi fb fbcon flac font-server foomaticdb ftp gd gdbm gif glut gmp gnome gnuplot gnutls gphoto2 gpm gstreamer gtk gtk2 guile haskell idn imagemagick imap imlib innodb jabber jack java jpeg junit kde ladcca ladspa lcms libg++ libwww mad maildir mbox mdb mha mhash mikmod mime mmx mmxext mng motif mozcalendar mozdevelop mozilla mozplaintext mozsvg mozxmlterm mp3 mpeg multipleip mysql ncurses nntp ntlm ofx ogg oggvorbis openal opengl oss pam pcre pda pdflib perl plotutils png postgres ppds print python qdbm qt quicktime readline rrdtool ruby samba sasl scanner sdl sftplogging slang smime sockets spell spl sqlite sse ssl subversion svg svga sysvipc szip tcltk tcpd tetex tiff tokenizer truetype truetype-fonts type1 type1-fonts udev usb vim vorbis wxwindows xbase xine xml2 xmlrpc xmms xosd xpm xv xvid zlib userland_GNU kernel_linux elibc_glibc"
Unset:  ASFLAGS, CTARGET, LANG, LC_ALL, LDFLAGS, LINGUAS, PORTDIR_OVERLAY


When a network interface is configured as type "adsl" in /etc/conf.d/net, then stopping that interface results in the following messages:

 * Stopping eth1
 *   Bringing down eth1
 *     Stopping ADSL for eth1
/usr/sbin/adsl-stop: line 193: [[: command not found
adsl-stop: The adsl-connect script (PID 13433) appears to have died                                                     [ !! ]
 *     Shutting down eth1 ...                                                                                           [ ok ]

The shell seems to be confused about the file and line # of the error; the error is actually in line 117 of /lib/rcscripts/net.modules.d/adsl, where the semicolon is missing at the end of the line before the backslash.

I will attach a diff.

Thanks,
Matt Harden
Comment 1 Matt Harden 2006-01-23 21:44:30 UTC
Created attachment 77967 [details, diff]
Patch to add a semicolon to fix syntax error
Comment 2 Andreas Kinzler 2006-01-25 07:57:43 UTC
This fix is perfectly OK and quite important. I created the same patch without knowing about this bugzilla entry.
Comment 3 Roy Marples (RETIRED) gentoo-dev 2006-01-25 09:18:55 UTC
Thanks for the patch.

Fixed in 1.11.14-r3