Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 119993 - Limit accepted number of lines in the comment field
Summary: Limit accepted number of lines in the comment field
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Infrastructure
Classification: Unclassified
Component: Bugzilla (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: Jeffrey Forman (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-22 16:36 UTC by Henrik Brix Andersen
Modified: 2011-10-30 23:14 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Sample JS (test.htm,540 bytes, text/html)
2006-05-18 15:37 UTC, Daniel Drake (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Henrik Brix Andersen 2006-01-22 16:36:32 UTC
It would be nice if bugzilla would enforce a limit on the number of lines (or just the number of characters) for the comments field (along with instructions to attach the "comment" as a text file instead).

The check should probably be made by the backend, not the frontend, in order to allow reporters to hit the "Back" button in their browser and cut-n-paste their comment to a file instead.

This would make it impossible to clutter a bug with long compilation output, kernel .config files etc. Stuff which really belongs in the attachment section. Needless to say, the limit should be set reasonably high in order for smaller compilation outputs to be posted as comments.
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2006-02-25 00:52:38 UTC
Not only comment field should be limited, summary needs limit as well:

http://bugs.gentoo.org/show_activity.cgi?id=124029

Comment 2 Jeffrey Forman (RETIRED) gentoo-dev 2006-03-11 05:13:44 UTC
This is definitely something upstream if it's going to be included in the back-end of bugzilla. I am no bugzilla programmer by any stretch of the imagination.
Comment 3 Daniel Drake (RETIRED) gentoo-dev 2006-05-18 15:35:40 UTC
Reopening as this is something being worked on
Comment 4 Daniel Drake (RETIRED) gentoo-dev 2006-05-18 15:37:15 UTC
Created attachment 87022 [details]
Sample JS

I understand that you are looking into actually placing a hard restriction via bugzilla's configuration, but I produced some simple javascript which implements what I was thinking of anyway. Either solution is good by me.
Comment 5 Jeffrey Forman (RETIRED) gentoo-dev 2006-05-19 05:18:06 UTC
Thanks to the work of Jakub and Daniel, we have instituted an 8000 character limit on the comment field. This will go live when i push bugstest out to bugs, just waiting on confirmation of the backend DB stuffs first.
Comment 6 Henrik Brix Andersen 2006-05-19 05:25:26 UTC
(In reply to comment #5)
> Thanks to the work of Jakub and Daniel, we have instituted an 8000 character
> limit on the comment field.

8000 characters? Why so high?

Comment 7 Jakub Moc (RETIRED) gentoo-dev 2006-05-19 05:32:47 UTC
(In reply to comment #6)
> 8000 characters? Why so high?


# emerge --info | wc -c
3332

And - I'm not using even remotely as many use flags as some of the people do. We should not nag them more than necessary to prevent posting huge crap like kernel .config or complete config.log
Comment 8 Henrik Brix Andersen 2006-05-19 05:37:04 UTC
(In reply to comment #7)
> # emerge --info | wc -c
> 3332

Hmm, I was actually hoping this would enforce people to attach their 'emerge --info' output instead of pasting it as a comment. Having a bug report with just three or four 'emerge --info' posts gets quite huge and is not easily parsed.


Comment 9 Jakub Moc (RETIRED) gentoo-dev 2006-05-19 05:40:29 UTC
(In reply to comment #8)
> Hmm, I was actually hoping this would enforce people to attach their 'emerge
> --info' output instead of pasting it as a comment. Having a bug report with
> just three or four 'emerge --info' posts gets quite huge and is not easily
> parsed.

Not a good idea at least until mime type autodetection either works correctly or is removed from bugzilla and it defaults to plaintext. I certainly don't want to be forced to edit the attachment mime type to be able to see plain emerge --info output. :)