Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 119902 - flag-o-matic.eclass fix to replace test_flag with test-flags().
Summary: flag-o-matic.eclass fix to replace test_flag with test-flags().
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Kevin F. Quinn (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-22 03:09 UTC by Peter Volkov (RETIRED)
Modified: 2006-01-22 09:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Patch for flag-o-matic.eclass. (flag-o-matic_test_flag_removal.diff,1.33 KB, patch)
2006-01-22 03:25 UTC, Peter Volkov (RETIRED) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Volkov (RETIRED) gentoo-dev 2006-01-22 03:09:45 UTC 
Today I used flag-o-matic to remove fstack-protector gcc flags. But during testing of my ebuild I saw the following message:
 * test_flag: deprecated, please use test-flags()!

The problem was in fstack-flags() function in flag-o-matic.eclass. Thus I've done trivial fix in eclass to replace all occurrences of test_flag on test-flags.

BTW. I know you know :). That test_flag() should not be removed from .eclass, as it is used in the tree. xorg-x11-6.8.2-r6.ebuild fex.

Patch follows...
Comment 1 Peter Volkov (RETIRED) gentoo-dev 2006-01-22 03:25:15 UTC 
Created attachment 77789 [details, diff]
Patch for flag-o-matic.eclass.

I think it's worth efforts to apply this patch to make the tree a litle bit more clean ;)
Comment 2 Kevin F. Quinn (RETIRED) gentoo-dev 2006-01-22 09:53:18 UTC 
I've committed an update to flag-o-matic which should resolve this; re-open if there are still problems.