For some reason the htop package does not include and icon or .desktop file. So I did. Enjoy and feel free to use. Note, the exec for the .desktop entry is for Eterm. You may want to change to xterm or do a test in the ebuild for one or the other or none. Also, the version is coded as 0.6 and this may be changed using sed in the ebuild too.
Created attachment 77720 [details] htop.desktop file
Created attachment 77721 [details] htop.png icon file
Does this make sense for console-only app?
Created attachment 77730 [details] Screen shot of htop in a WM I understand that POV, but I run it inside a WM and it works just as well and looks fine. This enhancement is completely non-essential, but I think it adds value. HTOP has uses inside a WM for killing runaway processes and finding CPU hogs, etc. JMHO.
Yeah, I'm also a htop user and I really like it. I'm just used to run it from command-line... :-) Let the gentoo-devs decide, then...
Hmm, I think I'd make it depend on x11-terms/xterm then... ok?
Well, this is dumb. We're talking about console app. I use it on several servers and I'm not gonna install X there just because of false dep. :-(
Oh, well, I forgot to mention that I would add a 'X' to IUSE :-)
Oh, well, that's fine, then...
Created attachment 77765 [details] htop menu screenshot It's really just a silly thing, but I think it does look nice on a menu. Makes it easier for the user too if they do have X. JM2C. Don't mean to make things more complex than they need to be. And, console users would not need it. In fact, I think you don't even need to make X an iuse at all. Just install the two files, .desktop and .png and be done with it. XDG specs will pick up the menu items if a menu program is used anyway. I would not even use DEPEND.
The USE-flag solution is the correct Gentoo-way. The Gentoo philosophy is based on minimalism (don't compile in what's not needed) and should IMHO apply to "useless" files as well. So, let's include the icon and .desktop file for X users ONLY.
Fine by me. Sometimes though, the effort to stop a few files from being installed exceeds the benefit derived by omitting them! For example, what would have happened if the distribution of htop INCLUDED these files? There are a whole bunch of apps which install everything that's included in the configure app unless it has a -without-feature. But really, we're talking about 2 files, 340 bytes! And, to make xterm a depend is not really right either. What if someone uses konsole, gnome-term, or Eterm and does not want xterm? That adds far more overhead. Anyway, enough. Whatever is decided is fine by me. I emailed upstream about this and hopefully new versions of htop will included these files. I do understand your POV, Radek. Completely. But in this case, I think it is cutting a very fine line.
Yup, you're right. It may not be worth the effort but you've just caught me in this period of my days when I'm trying to make Gentoo go embedded so for me even a single byte saved is a good one :-). I'm really happy there are people like you who contribute .desktop files cause I like them when I'm on my PC but when it comes to getting Gentoo to my Ipaq handheld, I'd prefer ALL non-crucial stuff to be disabled (therefore I need the USE-flag). The depend should read something like virtual/xterm or should be omitted at all.
FWIW, I heard from upstream, and he will be including both the icon and a slightly modified .desktop file in future releases of htop. Probably no reason to keep this bug open as the items are to be included. Maintainer, you can close this bug at your discretion. Maybe resolve UPSTREAM?
Closing since upstream will be including at some point in the future. No need for it here.