Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 11936 - EA/ACL patch needed in fileutils
Summary: EA/ACL patch needed in fileutils
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: x86 Linux
: High major (vote)
Assignee: Joachim Blaabjerg (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-12-10 22:24 UTC by Luke Holden
Modified: 2003-02-04 19:42 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Holden 2002-12-10 22:24:49 UTC
Right now the EA/ACL patches from http://acl.bestbits.at/download.html#Fileutils
are not being included in the fileutils package when building with ACL support.

Although this patch is not required to make ACL work... it makes since to include.

The patch adds support into the fileutil commands to handle dealing with EA/ACL
data. 

For example, using ls on an unpatched fileutils package does not show any
difference between a file using ACL's or not. (this is how things are right now
using the latest fileutils on gentoo 1.4.)

However, ls in the patched version shows a plus sign at the end of the
permission info letting the user know other permissions outside of the normal
unix permissions have been set. (ACL's in this case)

The fileutils modifications of course are not limited to this, See the EA/ACL
page for more details,

Right now I am using ACL's in a commercial environment... so I have to use one
of the patched versions of fileutils from the EA/ACL website. I would like to
see this functionality added to gentoo's fileutils by default when using ACL's.

Thanks =)
Comment 1 Joachim Blaabjerg (RETIRED) gentoo-dev 2002-12-11 07:52:40 UTC
From the fileutils ChangeLog: 
 
*fileutils-4.1.11 (25 Sep 2002) 
 
  25 Sep 2002; Martin Schlemmer <azarah@gentoo.org> : 
  Update version.  Seems acl is included in this release. 
 
It doesn't work as expected? Have you tried with the 4.1.8 ebuild? 
Comment 2 Luke Holden 2002-12-11 12:16:01 UTC
Do you mean the acl.c.diff in the files directory?  This actually is a rather small patch, and does not include anything from the EA/ACL patch at acl.beatbits.at  BTW... the patch from that site almost fully works against the latest fileutils tree. (some small differences)...  That is probably a good sign that the functionality from that patch does not exist in the latest version of fileutils.  (So in other words... it does not look like the default fileutils really know much about EA's or ACL's)  Again, the 'ls' example.  The ls from the latest fileutils included with gentoo does not show any difference between a file with ACL's and a file without.  The patched ls, on the other hand, shows a couple things it seems.  Files with EA's or ACL's have a + after the permission info when doing ls -l. Also I believe the actual permissions ls -l shows with the patched version is based on some of the ACL information. (the mask, and etc.. I believe.)   This of course is just an example.  Another example... the patched cp preservs ea/acl's, while the non patched does not.  (so copying a file with EA/ACL's would result in a file with nothing except any defaults set for your directory.)  Anyways... long story short... hehe... no it does not work as expected =)  (I dont think the 4.1.8 build would be any different, especially considering thats the build that the EA/ACL patches specifically target... and we are not currently applying those patches in our ebuild.) 
Comment 3 Luke Holden 2002-12-11 12:17:40 UTC
Ack... it seems I lost any text formatting when I posted =/ Sorry 
Comment 4 Joachim Blaabjerg (RETIRED) gentoo-dev 2002-12-11 12:45:19 UTC
Never mind the text formatting, it looked okay in the email ;) 
 
Non I was thinking about the xdelta patch in fileutils-4.1.8-r2.ebuild, isn't that some 
ACL stuff? 
Comment 5 Luke Holden 2002-12-11 12:50:34 UTC
Ahhhhh yes actually. That happens to be the same patch. 
 
There is a diff version of the patch availible... wonder why we have not ported it to the 
latest fileutils? 
 
So I guess this bug report should be changed to: 
fileutils-4.1.8-r2 being patched for ACL's, but fileutils-4.1.11 isnt. 
 
=) 
Comment 6 Joachim Blaabjerg (RETIRED) gentoo-dev 2002-12-11 13:25:23 UTC
And that's where my snippet from the ChangeLog comes in. ;) 
 
So, what I want to know now, is if 4.1.8-r2 works. If it does, I can just port the 
changes back into the 4.1.11 ebuild... So, feel like testing? :) 
Comment 7 Luke Holden 2002-12-11 18:05:59 UTC
Sure =)

Away from the office right now... but lets see if I can find a ssh client for 
windows hehe. Will let you know asap.
Comment 8 Luke Holden 2002-12-11 18:39:26 UTC
Installed fileutils-4.1.8-r2 and it works with acls as expected.

Sounds like someone is going to have fun porting the acl patch =)

Shoot me an email after its in the repo and I will give it a try and let you 
know how it goes so we can close this bug =)
Comment 9 Joachim Blaabjerg (RETIRED) gentoo-dev 2002-12-12 06:44:02 UTC
There, fileutils-4.1.11-r1 committed and ~ masked (x86 only). Reopen the bug if it 
doesn't work. Thanks! :)