Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 118926 - rp-pppoe bad USE flag ("X" versus "tcltk")
Summary: rp-pppoe bad USE flag ("X" versus "tcltk")
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo Dialup Developers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-13 14:17 UTC by Bastien Armand
Modified: 2006-01-14 03:12 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
rp-pppoe-3.5-r11.ebuild (rp-pppoe-3.5-r11.ebuild,2.36 KB, text/plain)
2006-01-13 22:56 UTC, Bastien Armand
Details
rp-pppoe-3.6.ebuild (rp-pppoe-3.6.ebuild,2.47 KB, text/plain)
2006-01-13 22:59 UTC, Bastien Armand
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bastien Armand 2006-01-13 14:17:22 UTC
Hi,

rp-pppoe use the "X" use flag, but in the rp-pppoe ebuild, we can see :
DEPEND="net-dialup/ppp
    X? ( dev-lang/tk )"

Since the X flag should only install xorg components and not tcl/tk, this line should be replaced by :
DEPEND="net-dialup/ppp
    tcltk? ( dev-lang/tk )"

This will avoid to install tcl/tk on system with USE="-tcltk" (or no USE).

I was not able to find similar bug, i hope it is not a duplicate.

Thanks to all gentoo Devs :)
Comment 1 Bastien Armand 2006-01-13 22:56:50 UTC
Created attachment 77049 [details]
rp-pppoe-3.5-r11.ebuild

ebuild with "tcltk" USE flag instead of "X" flag.
Comment 2 Bastien Armand 2006-01-13 22:59:09 UTC
Created attachment 77050 [details]
rp-pppoe-3.6.ebuild

ebuild with "tcltk" flag instead of "X" flag.
Comment 3 Alin Năstac (RETIRED) gentoo-dev 2006-01-14 02:22:28 UTC
The only configurable through useflags thing in rp-pppoe is to whether install the GUI part or not. Not so long ago, the rp-pppoe was depending on 2 useflags, X and tcltk, but got changed to this variant for solving bug 117963.

Flag shouldn't be used as filters but merely as feature enabling method. Since the feature would be in fact installation of a GUI interface to rp-pppoe and 
the only global useflag close to GUI selection is X, I chosed X.

The simple fact that users don't have tcltk selected isn't a guarantee that tcl or tk will not be installed. Think about what would happen when the user will emerge a package that depend unconditionally by tk, even if tcltk is disabled.
Comment 4 Bastien Armand 2006-01-14 02:59:58 UTC
Thanks for your response.

I agree with you on your flag explanation. (features vs mask).

However, since the rp-pppoe gui does depends on tk and not only on virtual/X11. I still think that the tcltk use flag is more accurate than the X flag. The two flags indicates an interface feature. 

With vlc, you should enable wxwindows to have the interface (X flag does not build the interface).

Anyway, I put -X in /etc/portage/package.use for rp-pppoe and will be happy with this one...

Reguards ;)
Comment 5 Alin Năstac (RETIRED) gentoo-dev 2006-01-14 03:12:44 UTC
X is the best useflag because is more intuitive. 
Besides, it is far less time consuming to install tk than the xorg package, so peeps would like to filter this thing out rather than tk. Therefore I think I would upset more users if I choose tcltk as gui enabling flag.