Bug 118890 – sysprof-1.0.1 (with module/userspace split)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description TGL 2006-01-13 09:18:08 UTC]

Here are is an ebuild for sysprof-1.0.1. I think this updated version is required for newest kernels (2.6.15).

Also, i've made some changes to the ebuild:
 - split module and GUI in two distinct ebuilds (dev-util/sysprof{,-module}), because i don't like to recompile some GTK stuffs when i install a new kernel. The GUI rdepends on the module. (Question: should the module PDEPEND on the GUI too? I'm not sure it would be much useful, but asking just in case...)
 - added libglade dep for the GUI.
 - added .desktop file creation for the GUI.
 - added >=2.6.11 kernel rdep for the module, since it's the required version (btw, is it okay to make versioned deps on virtuals like this?). Also added a pkg_setup() check, just to be sure (deps don't work that well here, because of SLOTs).
 - added a pkg_setup check for !HZ_100, as a workaround for the module crashing with HZ<200 because of a division by zero. Yep, i will send a proper patch upstream when i have time.
 - use convert_to_m() on the module's Makefile, since it was still using SUBDIRS.
 - removed a useless check for 2.6 kernel in the module's Makefile.

[Comment 1 TGL 2006-01-13 09:19:47 UTC]

Created attachment 77005 [details]
sysprof-1.0.1.ebuild

Now only installs the GUI part of sysprof.

[Comment 2 TGL 2006-01-13 09:20:51 UTC]

Created attachment 77006 [details]
sysprof-module-1.0.1.ebuild

New ebuild which installs the sysprof kernel module only. I think it belongs to "dev-util" too.

[Comment 3 TGL 2006-01-13 09:22:32 UTC]

Oh, i forgot to say that i've kept both ~amd64 and ~x86 keywords, since they were in the 1.0 ebuild, but i've actually tested that only on x86.

[Comment 4 TGL 2006-01-13 11:38:32 UTC]

Created attachment 77021 [details, diff]
sysprof-module-1.0.1-INTERVAL_should_not_be_zero.patch

For information, here is the patch i've sent upstream for the "HZ < 200" bug. It may be used to replace the "!HZ_100" check in pkg_setup(), if you think that's better.

[Comment 5 SpanKY 2006-01-13 16:20:21 UTC]

thanks, 1.0.1 in portage

lemme know how the patch goes

[Comment 6 TGL 2006-01-13 16:37:58 UTC]

Thanks for the quick inclusion Mike.

About the patch, I've just received a reply from Soeren (upstream), and he actually already had something similar in his cvs HEAD. So, he has now backported it to MAIN, and it will be fixed in a later 1.0.2 version (don't know when).

Soeren's version of the fix is here:
http://cvs.gnome.org/viewcvs/sysprof/module/sysprof-module.c?r1=1.9.2.2&r2=1.9.2.3&only_with_tag=sysprof-1-0&makepatch=1&diff_format=u

[Comment 7 SpanKY 2006-01-13 16:44:35 UTC]

they seem to be functionally equivalent so i wont bother changing the patch

thanks for the update