Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 118212 - ptlink-ircd-6.19.5 update and ebuild cleanup
Summary: ptlink-ircd-6.19.5 update and ebuild cleanup
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Low enhancement (vote)
Assignee: Packages in net-irc
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2006-01-07 11:42 UTC by Pawel Madej aka Nysander
Modified: 2006-11-19 10:31 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ptlink-ircd-6.19.5.ebuild (ptlink-ircd-6.19.5.ebuild,2.82 KB, text/plain)
2006-01-07 11:42 UTC, Pawel Madej aka Nysander
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Madej aka Nysander 2006-01-07 11:42:24 UTC
new version of ptlink-ircd is out 6.19.5 ebuild provided and compile wihout problems. Please file it into portage
Comment 1 Pawel Madej aka Nysander 2006-01-07 11:42:57 UTC
Created attachment 76468 [details]
ptlink-ircd-6.19.5.ebuild
Comment 2 Petteri Räty (RETIRED) gentoo-dev 2006-01-08 07:15:04 UTC
Some feedback to improve your ebuild writing skills:
KEYWORDS="~x86 ~ppc ~sparc"
http://dev.gentoo.org/~ciaranm/docs/mw-faq/keywords.txt

IUSE="ssl utf8" 
Probably better to use the global unicode use flag.
betelgeuse@pena ~ $ euse -i unicode
global use flags (searching: unicode)
************************************************************
[+ C  ] unicode - Adds support for Unicode

DEPEND="sys-libs/zlib
zlib is part of system:
http://dev.gentoo.org/~plasmaroo/devmanual//general-concepts/dependencies/

	econf \
		--disable-ipv6 --enable-halfops \
Any special reason to disable-ipv6 instead of use flagging it?
If so it should be commented in the ebuild.

	emake CFLAGS="${CFLAGS}" || die "emake failed"
I don't see any reason for this CFLAGS handling?

src_install() {
Any special reason you can't use upstream make install?
http://dev.gentoo.org/~plasmaroo/devmanual//ebuild-writing/functions/src_install/

	use ssl && (
		insinto /etc/ptlink-ircd
		docert server || die "docert failed"
		mv ${D}/etc/ptlink-ircd/server.crt ${D}/etc/ptlink-ircd/server.cert.pem
		mv ${D}/etc/ptlink-ircd/server.csr ${D}/etc/ptlink-ircd/server.req.pem
		mv ${D}/etc/ptlink-ircd/server.key ${D}/etc/ptlink-ircd/server.key.pem
	)

( ) starts a subshell.  The correct syntax is
if use ssl; then
    true
fi

	enewuser ptlink-ircd

	chown ptlink-ircd \
		${ROOT}/{etc,var/{log,lib}}/ptlink-ircd \
		${ROOT}/etc/ptlink-ircd/server.key.pem

You should add the user in pkg_setup so that you can change the permissions in src_install instead of messing with the live filesystem.
http://dev.gentoo.org/~plasmaroo/devmanual//ebuild-writing/users-and-groups/

Please note that these comments are based on only looking at the ebuild. I did not test it in practise.
Comment 3 Petteri Räty (RETIRED) gentoo-dev 2006-01-08 07:20:14 UTC
Ah sorry I thought this was a new package instead of a version bump so the keyword comment of course does not apply.
Comment 4 Markus Ullmann (RETIRED) gentoo-dev 2006-11-19 10:31:10 UTC
we have a bumped version in tree already -> FIXED